Fix pbdv for large arguments - #255
Open
verma-divyanshu-git wants to merge 2 commits into
Open
Conversation
Author
|
@lucascolley, could you please take a look when you have time? this is the xsf fix for scipy/scipy#25814, and the scipy PR depends on it. thanks. |
Author
|
@lucascolley @steppi @j-bowhay, could one of you please review this when you have time? scipy/scipy#25966 is waiting on this change. the branch is mergeable, the full xsf suite passes (410 tests), and the scipy.special suite passes (8,769 tests). i'm happy to address any changes, if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses scipy/scipy#25814.
Tests
pixi run testspixi run format-dry-errorAI disclosure
I used AI assistance to understand the repository structure and generate an initial draft of the potential fix and regression tests.
The initial drafts of v small parts of
include/xsf/par_cyl.handtests/scipy_special_tests/test_pbdv.cppwere AI-assisted.I reproduced the reported failures, traced the two numerical root causes, revised the implementation based on my own understanding, verified the reference values against mpmath, and ran the full test and formatting checks.
I reviewed the final code and take responsibility for it.