MAINT: refactor bivariate normal functions - #256
Merged
Conversation
github-actions
Bot
added
the
Maintenance
fbourgey
changed the title
fbourgey
commented
Aug 20, 2026
| return false; | ||
| } | ||
|
|
||
| // Positive nodes and weights of symmetric Gauss-Legendre rules on [-1, 1]. |
Member
Author
There was a problem hiding this comment.
added this small comment
Member
Author
|
@j-bowhay does this look good to you? |
Member
Author
|
ok to merge? |
dschmitz89
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
As I was working on adding the trivariate normal cdf (see #98), I think we should move the bivariate normal cdf to a separate file for maintainability.
Additional information
AI Generation Disclosure
Asked Codex to make the move for me and checked what it did.