chore: ignore the local live-provider probes - #1007
Merged
Merged
Conversation
Seven probe scripts sat untracked in `tool/` through the whole 2.2.0 release: `live_model_compare`, `live_openai`, `live_openai_client_check`, `live_openrouter`, `live_own_server`, `live_routing_policy` and `verify_openai_key`. They take a key as a file-path argument rather than embedding one, so the exposure was never the key. The risk is a `git add -A` sweeping an ad-hoc script into a release branch, and `git status` listing seven files that are neither wanted nor ignored makes that easier, not harder. `tool/policy_snapshot.dart` is a committed tool and stays tracked; the pattern is scoped to the probes. `docs/ai-model-candidates.md` listed `tool/live_routing_policy.dart` under "In-repo files cited" as a link, which resolved to a 404 on github.com and now would not even be a file the repo could contain. It is named there instead, with a line saying why it is not committed. The two other references to these scripts are code spans in command examples, which were never links.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are narrowly scoped to ignore rules and documentation cleanup, and the updated docs no longer link to an intentionally uncommitted local probe.
Pull request overview
This PR prevents locally-created “live provider probe” Dart scripts under tool/ from showing up as untracked changes (and from being accidentally committed), while keeping the one intentionally-tracked tool (tool/policy_snapshot.dart) unaffected. It also updates documentation to stop linking to a probe script that is intentionally not committed.
Changes:
- Add
.gitignorerules fortool/live_*.dartandtool/verify_openai_key.dart. - Replace a broken in-repo link in
docs/ai-model-candidates.mdwith a non-linked mention explaining why the probe is not committed.
File summaries
| File | Description |
|---|---|
docs/ai-model-candidates.md |
Removes the broken link to an untracked probe script and documents why it’s referenced but not committed. |
.gitignore |
Ignores local live-provider probe scripts while leaving tool/policy_snapshot.dart tracked. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven probe scripts have been sitting untracked in
tool/—live_model_compare,live_openai,live_openai_client_check,live_openrouter,live_own_server,live_routing_policyandverify_openai_key. They surfaced in the pre-merge audit of #988, whereghwarned about "7 uncommitted changes" on every command run against the release branch.They read a key from a file path passed as an argument rather than embedding one, and the only key-shaped literal in them is 64 zeros — so the exposure was never a leaked key. The risk is narrower and duller: a
git add -Asweeping an ad-hoc script into a release branch, and seven files that are neither wanted nor ignored making that easier rather than harder.tool/policy_snapshot.dartis a committed tool and stays tracked. The pattern is scoped to the probes, andgit check-ignoreconfirms both halves:The one link that had to move
docs/ai-model-candidates.mdlistedtool/live_routing_policy.dartunder "In-repo files cited" as a relative link. That was already a 404 on github.com while the file was merely untracked; once it is ignored, the heading is wrong as well as the link. It is now named in a sentence that says why it is not committed, and the two remaining entries under that heading are both real committed files.The other two references to these scripts —
docs/ai-openai-behavioural-screen.md:14and:192— are code spans inside command examples, never links, and are untouched.Verified
test/unit_test/ai_architecture_doc_test.dartpasses; no heading changed, so no anchor moved.git statusis clean with the probes present on disk.