[6.x] Use object-contain instead of object-cover in the thumbnail view - #12755
Merged
Conversation
…bnail view, and add a slight background when it doesn't fill the container so it doesn't look too float-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #12678.
I tested a few different image crops, and there seems to be no disadvantage to
object-contain—it only kicks in when images have more of a letterbox crop.The only drawback may be that images feel "floaty" when they don't fill the container, so I've added a subtle background to offset this, which you can see in the top right image in this gallery