[6.x] Fix focal point editor performance with large images - #15311
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Fix focal point editor performance with large images#15311duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
…view image improves performance when working with large source images (#15270)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the focal point editor becomes slow when working with large source images.
This was happening because the editor's preview crops were rendered using the full, original asset image nine times over.
This PR fixes it by using the asset's thumbnail instead of the full preview image for those crops. Note that this means the images in the focal point editor may appear lower quality or more blurry than they actually are — that's the trade-off of using the thumbnail here.
Fixes #15270