[6.x] Use ->getAuthIdentifier() instead of ->id() - #15313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Auth::guard()function returnsAuthenticatable|null. The Authenticatable contract doesn't have anid()function, instead it hasgetAuthIdentifier().Note that the getAuthIdentifier function is already overwritten in the default
Userauthenticatable class that Statamic uses, so I don't see any issue with changing this to the standard function here.We ran into an issue with this, as this function was being called upon our own
Usermodel that we use in our storefront. While that's probably going to be a separate issue to look into, I figured it was at least worth making this change regardless.