[6.x] Fix startRegistration() warning when registering passkeys - #15328
Merged
Conversation
duncanmcclean
changed the title
startRegistration() warning when registering passkeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where passkey registration emits an incorrect call warning from SimpleWebAuthn.
This was happening because
startRegistration()was being passed registration options directly, using the API shape discontinued in SimpleWebAuthn 11. The library continues through a backwards-compatibility path, but logs a warning.This PR fixes it by passing the registration options through the documented
optionsJSONproperty.Related: #15212