Add TokenRepository::all() for unexpired tokens - #608
Open
jackmcdade wants to merge 3 commits into
Open
Conversation
The cms TokenRepository contract now requires all(). Implement it so shareable preview links can reuse tokens on Eloquent-backed sites. Co-authored-by: Cursor <cursoragent@cursor.com>
ryanmitchell
left a comment
ryanmitchell
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't all() just return all regardless of whether they are expired or not?
Do not filter by expiry — that is the caller's concern. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
Yup. Silly robot. It got a bit eager with this PR. |
CMS 6.29 assigns sequential order on save. Snapshot orders before the tree save so prefer-stable and prefer-lowest both pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenRepository::all()so this package satisfies the new method onStatamic\Contracts\Tokens\TokenRepository([6.x] Shareable draft and revision preview links cms#15274).Test plan
TokenRepositoryTest::it_gets_all_non_expired_tokenspassesMade with Cursor