Skip to content

Annotate Checkout Element presentation methods with MainThread #14351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cttsai-stripe wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Annotate Checkout Element presentation methods with MainThread #14351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions paymentsheet/src/main/java/com/stripe/android/elements/PaymentElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.stripe.android.elements
import android.os.Parcelable
import androidx.annotation.ColorInt
import androidx.annotation.FontRes
import androidx.annotation.MainThread
import androidx.annotation.RestrictTo
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
Expand Down Expand Up @@ -38,6 +39,7 @@ class PaymentElement @Inject internal constructor(
/**
* Presents a sheet for the customer to select or manage their payment method.
*/
@MainThread
fun present() {
contentHelper.presentPaymentOptions()

@cttsai-stripe cttsai-stripe Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mark out internal implementations as well as a reminder for ourselves.

}
Expand Down
2 changes: 2 additions & 0 deletions paymentsheet/src/main/java/com/stripe/android/elements/ShippingAddressElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.stripe.android.elements
import android.os.Parcelable
import androidx.activity.result.ActivityResultCaller
import androidx.activity.result.ActivityResultLauncher
import androidx.annotation.MainThread
import androidx.annotation.RestrictTo
import androidx.lifecycle.DefaultLifecycleObserver
import androidx.lifecycle.LifecycleOwner
Expand Down Expand Up @@ -43,6 +44,7 @@ class ShippingAddressElement @Inject internal constructor(
)
}

@MainThread
fun present() {
if (stateHolder.state == null) {
errorReporter.report(
Expand Down
Loading