Route Embedded saved payment method selection through a handler - #14393
Draft
cttsai-stripe wants to merge 3 commits into
Draft
Route Embedded saved payment method selection through a handler#14393cttsai-stripe wants to merge 3 commits into
cttsai-stripe wants to merge 3 commits into
Conversation
3 tasks
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
cttsai-stripe
force-pushed
the
cttsai/embedded-saved-method-selection-handler
branch
from
September 4, 2026 18:40
0ec1832 to
d94ed8f
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embedded saved payment method selection still commits the selection immediately before invoking the existing row-selection callback.
This PR moves that sequence behind an internal, select-only
EmbeddedSavedPaymentMethodSelectionHandler. The Embedded vertical-layout factory delegates saved method selection to the handler, while callers without a handler retain the existing direct selection path.What changed
What stays the same
Motivation
Checkout needs to perform work before completing saved payment method selection. Establishing the routing boundary separately keeps the behavior change in #14340 focused while preserving existing Embedded behavior here.
Testing
Coverage verifies that the default handler commits before invoking the callback, that the interactor delegates without duplicating the update or callback, and that the existing fallback behavior remains unchanged.
Focused handler and interactor tests passed. The path-aware pre-push hook passed
:paymentsheet:apiCheckand:paymentsheet:detekt.CI: pending.
Screenshots
Not applicable. This routing refactor has no UI changes.
Committed and created by Codex.