Fail fast on intermediate Bitrise test failures - #14396
Draft
cttsai-stripe wants to merge 2 commits into
Draft
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop failed intermediate Bitrise Gradle test attempts early, then retry with the existing cleanup flow.
Motivation
An instrumentation test failure is reported before the Gradle process finishes all remaining work. The retry wrapper currently waits for the complete failed attempt, which consumes CI time before starting the next attempt.
What changed
--fail-fast-testsmode to the retry wrapper and enable it at the seven existing instrumentation and PaymentSheet E2E retry call sites.There were failing tests.marker.What stays the same
Coverage
The process suite proves intermediate termination and retry, result capture before overwrite, graceful final-attempt completion, forced termination after the grace period, non-test failure preservation, no orphaned child process, and final exit-status preservation.
Testing
Local checks passed on this head: both Python suites passed with 6 tests each, Python compilation passed,
bash -npassed, shellcheck passed,bitrise validatepassed with Bitrise CLI 2.43.3, the repository pre-pushdetekt apiCheckpassed for both pushes, andgit diff --checkpassed. CI will run for this draft PR.Screenshots
Not applicable. This changes CI process control only.
Changelog
No user-facing SDK change. No changelog entry is required.
Committed and created by Codex.