Route direct vertical payment selections through a handler - #14428
Draft
cttsai-stripe wants to merge 3 commits into
Draft
Route direct vertical payment selections through a handler#14428cttsai-stripe wants to merge 3 commits into
cttsai-stripe wants to merge 3 commits into
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
cttsai-stripe
commented
Sep 4, 2026
cttsai-stripe
left a comment
cttsai-stripe
left a comment
Contributor
Author
There was a problem hiding this comment.
Pure refactoring. Expecting no behavioral change.
| updateSelection = updateSelection, | ||
| verticalPaymentSelectionHandler = ImmediateVerticalPaymentSelectionHandler( | ||
| updateSelection = { selection, isUserInput -> updateSelection(selection, isUserInput) }, | ||
| completionAction = null, |
Contributor
Author
There was a problem hiding this comment.
invokeRowSelectionCallback was not passed in and default null, so here is null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct vertical saved-method, Google Pay, and Link selections now route through
VerticalPaymentSelectionHandler.The immediate handler preserves the existing
isUserInputflags, updates selection before invoking completion, and removesinvokeRowSelectionCallbackfromDefaultPaymentMethodVerticalLayoutInteractor.Committed and created by Codex.
Motivation
Embedded immediate-action flows need selection updates and completion to share one ordered boundary. This refactor centralizes that routing without changing existing selection semantics.
New payment-method selection remains in the existing form-helper
selectionUpdaterflow. Checkout tax, pending state, lifecycle, and Manage behavior are unchanged.Testing
Handler coverage verifies saved methods use
isUserInput = true, while Google Pay and Link usefalse, and that selection updates occur before completion. Interactor coverage verifies all three direct selections delegate to the handler without a second interactor-level selection update.No local Gradle or device checks were run. CI is pending.
Screenshots
N/A. This is internal routing only and has no intended visual change.
Changelog
N/A. No public API or user-visible behavior change.