Skip to content

chore: allow cve checker to run on any image specified by hand #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamassoltesz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: allow cve checker to run on any image specified by hand #1175

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa1bcc9
chore: allow cve checker to run on any image specified by hand
tamassoltesz Aug 6, 2025
5eae8db
Update Azure Container Scan action version and add trivy version
tamassoltesz Apr 3, 2026
108e6bf
Fix trivy version format in container-check.yml
tamassoltesz Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/container-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ name: Container Security Scan
on:
# Allow manual triggering
workflow_dispatch:
inputs:
image_name:
type: string
description: 'Docker image name to scan'
required: false
default: 'supertokens/supertokens-postgresql:latest'

# Run automatically once a day at 2 AM UTC
schedule:
Expand All @@ -19,7 +25,7 @@ jobs:
uses: Azure/container-scan@v0
continue-on-error: true
with:
image-name: supertokens/supertokens-postgresql:latest
image-name: ${{ github.event.inputs.image_name }}

@graphite-app graphite-app Bot Apr 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical bug: When the workflow runs via the schedule trigger (line 14), github.event.inputs.image_name will be null/empty because scheduled workflows don't have inputs. This will cause the container scan to fail on the daily automated runs.

Fix: Use a fallback to the default image:

image-name: ${{ github.event.inputs.image_name || 'supertokens/supertokens-postgresql:latest' }}

The same issue exists on lines 49 and 85 where the image name is used in output messages.

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

severity-threshold: LOW
run-quality-checks: false
env:
Expand All @@ -39,7 +45,7 @@ jobs:
run: |
echo "summary<<EOF" >> $GITHUB_OUTPUT

echo "**Image:** \`supertokens/supertokens-postgresql:latest\`\n" >> $GITHUB_OUTPUT
echo "**Image:** \`${{ github.event.inputs.image_name }}\`\n" >> $GITHUB_OUTPUT
echo "**Scan Date:** \`$(date -u)\`\n" >> $GITHUB_OUTPUT
echo "\n" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -75,7 +81,7 @@ jobs:

- name: Add to Action Summary
run: |
echo "**Image:** \`supertokens/supertokens-postgresql:latest\`" >> $GITHUB_STEP_SUMMARY
echo "**Image:** \`${{ github.event.inputs.image_name }}\`" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "**Scan Date:** \`$(date -u)\`" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
Expand Down
Loading