Skip to content

Update projects.yml - #3

Open
dbu wants to merge 1 commit into
symfony_cmffrom
up-phpunit-version
Open

Update projects.yml#3
dbu wants to merge 1 commit into
symfony_cmffrom
up-phpunit-version

Conversation

@dbu

@dbu dbu commented Feb 23, 2018

Copy link
Copy Markdown
Member

getting symfony-cmf/Testing#168 ready

@ElectricMaxxx ElectricMaxxx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question.

Comment thread config/projects.yml
docs_path: 'components/testing'
deprecation_warnings: "/.*each.*/"
php: ['7.1', '7.2']
phpunit_version: 6.5

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have something, what renders that information to the right places? You should edit the templates too then.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i expected this to be translated to

- SYMFONY_PHPUNIT_VERSION={{ phpunit_version }}
- am i wrong with that assumption?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be correct, can your run it for testing lokal without pushing it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately not: ./dev-kit dispatch --with-files testing

Files for master
----------------

diff --git a/composer.json b/composer.json
index de4cb3b..085c9ef 100644
--- a/composer.json
+++ b/composer.json
@@ -18,22 +18,22 @@
         "friendsofsymfony/jsrouting-bundle": "^1.1 || ^2.1",
         "jackalope/jackalope": "^1.3",
         "jackalope/jackalope-doctrine-dbal": "^1.3",
-        "symfony/browser-kit": "^2.8 || ^3.0 || ^4.0",
-        "symfony/console": "^2.8 || ^3.0 || ^4.0",
-        "symfony/css-selector": "^2.8 || ^3.0 || ^4.0",
-        "symfony/debug": "^2.8 || ^3.0 || ^4.0",
-        "symfony/dependency-injection": "^2.8 || ^3.0 || ^4.0",
-        "symfony/doctrine-bridge": "^2.8 || ^3.0 || ^4.0",
-        "symfony/framework-bundle": "^2.8.1 || ^3.0 || ^4.0",
-        "symfony/http-foundation": "^2.8 || ^3.0 || ^4.0",
-        "symfony/http-kernel": "^2.8 || ^3.0 || ^4.0",
-        "symfony/monolog-bundle": "^3.1",
-        "symfony/process": "^2.8 || ^3.0 || ^4.0",
-        "symfony/security-bundle": "^2.8 || ^3.0 || ^4.0",
-        "symfony/twig-bundle": "^2.8 || ^3.0 || ^4.0"
+        "symfony/browser-kit": "^2.8 || ^3.3 || ^4.0",
+        "symfony/console": "^2.8 || ^3.3 || ^4.0",
+        "symfony/css-selector": "^2.8 || ^3.3 || ^4.0",
+        "symfony/debug": "^2.8 || ^3.3 || ^4.0",
+        "symfony/dependency-injection": "^2.8 || ^3.3 || ^4.0",
+        "symfony/doctrine-bridge": "^2.8 || ^3.3 || ^4.0",
+        "symfony/framework-bundle": "^2.8 || ^3.3 || ^4.0",
+        "symfony/http-foundation": "^2.8 || ^3.3 || ^4.0",
+        "symfony/http-kernel": "^2.8 || ^3.3 || ^4.0",
+        "symfony/monolog-bundle": "~3.1",
+        "symfony/process": "^2.8 || ^3.3 || ^4.0",
+        "symfony/security-bundle": "^2.8 || ^3.3 || ^4.0",
+        "symfony/twig-bundle": "^2.8 || ^3.3 || ^4.0"
     },
     "require-dev": {
-        "symfony/phpunit-bridge": "^4.0"
+        "symfony/phpunit-bridge": "^3.3 || ^4.0"
     },
     "autoload": {
         "psr-4": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall i do that for you on our "master"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have the time to do so, yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants