feat(editor): Ctrl+A selects every layer so Delete clears the canvas - #61
Merged
Conversation
The Select phase already treats Ctrl+A as "select everything"; the edit phase now does the same, filling the existing multi-selection so Delete, group move and the group bounds all work as they already do for a marquee selection. Clicking empty canvas drops the group, as it does for any other multi-selection. Emptying the canvas also restarts marker numbering, which the same undo restores. A group selection now outlines each member, not only the union: selecting everything used to draw one faint box with no way to tell what was in it. The union stays as the group's extent, drawn fainter behind the members. This also fixes flat arrows and lines, whose bounds have zero height, isEmpty() reported them as nothing, so they were dropped from the group's extent and drew no outline at all despite being selected and deletable. Both apply to the existing marquee selection too. Smoke: Delete with nothing selected as a no-op, a click dropping the group, Ctrl+A drawing a visible indicator, Ctrl+A + Delete clearing four layers as one undo step, and marker numbering restarting at 1.
tobi
force-pushed
the
feat/select-all-delete
branch
from
August 21, 2026 23:20
d5c9409 to
63b57ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Select phase already treats
Ctrl+Aas "select everything", so the edit phase does the same now, filling the multi-selection that's already there.Deleteclears the canvas, group move and group bounds work as they do for a marquee, and clicking empty canvas drops the group. Clearing also restarts counter numbering, which the same undo puts back.While I was in there: a group selection outlines each member now, not just the union, so you can see what's in the group rather than only its extent. The union survives as the group's extent, drawn fainter behind.
That turned out to fix flat arrows and lines too. Their bounds have zero height, so
isEmpty()called them nothing and they were dropped from the extent and drew no outline, despite being selected and about to be deleted. Both changes apply to the marquee selection, which had the same blind spot.runSelectAllDeleteSmoke(exit 101):Deletewith nothing selected does nothing, a click drops the group,Ctrl+Adraws a visible indicator,Ctrl+AthenDeleteclears four layers as one undo step, and numbering restarts at 1.