feat(editor): the layer you pick up comes to the top - #66
Merged
Conversation
Layers stacked in the order they were drawn, and nothing but redrawing could change it, a text under an arrow stayed under it. Picking a layer up now raises it, from any tool, as its own undo step. Text and counters are painted after everything else regardless: a label buried under a shape is a label nobody can read, and the number pointing at it belongs above even that. The hit test walks the same order, so what you click is what you see on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layers stacked in the order you drew them and nothing but redrawing could change it, so a text label that ended up under an arrow stayed there.
Picking a layer up raises it now, from any tool, as its own undo step. Text and counters are painted after everything else regardless: a label buried under a shape is a label nobody can read, and the number pointing at it belongs above even that. The hit test walks the same order as the painter, so what you click is what you can see.
runLayerOrderSmoke(exit 122): a layer drawn first and then picked up covers one drawn later, the raise is a single undo step, and text over a shape stays legible in the export whatever order they were drawn in. That check uses a shape painted in the same pass on purpose, since a redaction would have passed regardless of ordering.