Skip to content
This repository was archived by the owner on Feb 27, 2021. It is now read-only.

Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub - #12

Open
tracyloisel wants to merge 4 commits into
ursm:masterfrom
tracyloisel:master
Open

Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub#12
tracyloisel wants to merge 4 commits into
ursm:masterfrom
tracyloisel:master

Conversation

@tracyloisel

@tracyloisel tracyloisel commented Sep 2, 2019

Copy link
Copy Markdown

Since the 1st of February in 2019, gem google-cloud-pubsub has been updated (0.34.0 version) and it brokes compatibility with this current gem.

Extract from google-cloud-pubsub's changelog, 0.34.0 version :

  • Remove the #delay alias for modify_ack_deadline.
    • Users should use the modify_ack_deadline and modify_ack_deadline!
      methods directly instead.

…ogle-cloud-pubsub gem update, users should use the modify_ack_deadline and modify_ack_deadline! instead of delay which was previously an alias
@tracyloisel tracyloisel changed the title Compatibility with update at gem google google-cloud-pubsub Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub Sep 2, 2019
@dibusan

dibusan commented Jan 27, 2020

Copy link
Copy Markdown

@ursm When could we expect this PR to be merged and released if at all?
@tracyloisel Is there a workaround I could do? My worker is failing with

ERROR -- : undefined method 'delay!' for #<Google::Cloud::PubSub::ReceivedMessage:0x00560d163808a0> (NoMethodError)
/app/vendor/bundle/ruby/2.4.0/gems/activejob-google_cloud_pubsub-0.7.1/lib/activejob-google_cloud_pubsub/worker.rb:38:in `block (2 levels) in run'

@hkrdrm

hkrdrm commented Feb 21, 2020

Copy link
Copy Markdown

@ursm Any chance this patch can get merged upstream or is this repo pretty much dead in the water. I've playing with @tracyloisel fork and couple others but seems like I'm going to just have to fork and pull in patches from all the other forks. If this repo is dead do we have anyone willing to takeover and maintain it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants