This repository was archived by the owner on Feb 27, 2021. It is now read-only.
Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub - #12
Open
tracyloisel wants to merge 4 commits into
Open
Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub#12tracyloisel wants to merge 4 commits into
tracyloisel wants to merge 4 commits into
Conversation
…ogle-cloud-pubsub gem update, users should use the modify_ack_deadline and modify_ack_deadline! instead of delay which was previously an alias
|
@ursm When could we expect this PR to be merged and released if at all? |
|
@ursm Any chance this patch can get merged upstream or is this repo pretty much dead in the water. I've playing with @tracyloisel fork and couple others but seems like I'm going to just have to fork and pull in patches from all the other forks. If this repo is dead do we have anyone willing to takeover and maintain it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the 1st of February in 2019, gem google-cloud-pubsub has been updated (0.34.0 version) and it brokes compatibility with this current gem.
Extract from google-cloud-pubsub's changelog, 0.34.0 version :
methods directly instead.