Skip to content

[Bugfix] Correct prompt lengths for timed_traces benchmark #45423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdoublep merged 3 commits into from
Aug 13, 2026
+8 −4
Merged

[Bugfix] Correct prompt lengths for timed_traces benchmark #45423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bea164c
Proper tokens passing for timed_traced benchmark
s3woz Jun 12, 2026
d675770
Backend compatibility check
s3woz Aug 13, 2026
9ff8541
Merge branch 'main' into timed_trace_fix
s3woz Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions vllm/benchmarks/datasets/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class SampleRequest:
Represents a single inference request for benchmarking.
"""

prompt: str | list[str] | list[dict]
prompt: str | list[str] | list[int] | list[dict]
prompt_len: int
expected_output_len: int = 0
multi_modal_data: MultiModalDataDict | dict | list[dict] | None = None
Expand Down Expand Up @@ -1572,7 +1572,6 @@ def sample(
prompt_ids = self._expand_prompt(
entry.get(self.label_hash_ids, []), input_length, tokenizer
)
prompt = tokenizer.decode(prompt_ids)

# Get timestamp with proper error handling
ts_value = entry.get(self.label_ts)
Expand All @@ -1588,7 +1587,7 @@ def sample(

samples.append(
SampleRequest(
prompt=prompt,
prompt=prompt_ids,
Comment thread
tdoublep marked this conversation as resolved.
prompt_len=prompt_len,
expected_output_len=new_output_len,
lora_request=None,
Expand Down
2 changes: 1 addition & 1 deletion vllm/benchmarks/lib/endpoint_request_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def add_chunk(self, chunk_bytes: bytes) -> list[str]:
class RequestFuncInput:
"""The input for the request function."""

prompt: str | list[str] | list[dict[str, Any]]
prompt: str | list[str] | list[int] | list[dict[str, Any]]
api_url: str
prompt_len: int
output_len: int
Expand Down
5 changes: 5 additions & 0 deletions vllm/benchmarks/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2097,6 +2097,11 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
args.ignore_eos = True

if args.dataset_name == "timed_trace":
if args.backend not in ("vllm", "openai"):
raise ValueError(
"timed_trace dataset passes pre-tokenized prompts (list[int])"
" and requires a completions backend ('vllm' or 'openai')."
)
# timed_trace carries per-request timestamps;
# ignore EOS so generation runs to the trace's specified output length,
# and default to using those timestamps for scheduling unless the user
Expand Down
Loading