Skip to content

[Misc] Remove override_attention_dtype - #48684

Merged
yewentao256 merged 8 commits into
vllm-project:mainfrom
wangxiyuan:remove_override_attention_dtype
Aug 14, 2026
Merged

[Misc] Remove override_attention_dtype#48684
yewentao256 merged 8 commits into
vllm-project:mainfrom
wangxiyuan:remove_override_attention_dtype

Conversation

@wangxiyuan

@wangxiyuan wangxiyuan commented Jul 15, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Purpose

override_attention_dtype is only used for V0 and has been removd from #25351 long time ago. It's safe to remove it now.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

claude[bot]
claude Bot reviewed Jul 15, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

yewentao256
yewentao256 approved these changes Jul 15, 2026
View reviewed changes

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2026
@wangxiyuan

wangxiyuan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@yewentao256 double checked the CI log, the error looks doesn't relate to this change.

@yewentao256
yewentao256 enabled auto-merge (squash) July 22, 2026 18:46
@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Hi @wangxiyuan, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wangxiyuan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Aug 5, 2026
@wangxiyuan
[Misc] Remove override_attention_dtype
4c2b423 
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
auto-merge was automatically disabled August 6, 2026 06:29

Head branch was pushed to by a user without write access

@wangxiyuan
wangxiyuan force-pushed the remove_override_attention_dtype branch from ebf7591 to 4c2b423 Compare August 6, 2026 06:29
@mergify mergify Bot removed the needs-rebase label Aug 6, 2026
yewentao256
yewentao256 reviewed Aug 6, 2026
View reviewed changes

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci run

yewentao256
yewentao256 reviewed Aug 11, 2026
View reviewed changes

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci run

yewentao256
yewentao256 reviewed Aug 13, 2026
View reviewed changes

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wangxiyuan you might need to enable CI by yourself

/ci run

@wangxiyuan

wangxiyuan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83754 for commit 21db591cb0bc.

@wangxiyuan

wangxiyuan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@yewentao256 sure. I assumed the command is for committer only.

@wangxiyuan

wangxiyuan commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@yewentao256 ready to go now.

@yewentao256
yewentao256 merged commit cdc4824 into vllm-project:main Aug 14, 2026
101 checks passed
Alessandra005 pushed a commit to Alessandra005/vllm that referenced this pull request Aug 17, 2026
@wangxiyuan @mergify @Alessandra005
[Misc] Remove override_attention_dtype (vllm-project#48684)
47a84d1 
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Alessandra005 <aurib032@fiu.edu>
zyp2014 pushed a commit to zyp2014/vllm that referenced this pull request Aug 21, 2026
@wangxiyuan @mergify zhangyp26
[Misc] Remove override_attention_dtype (vllm-project#48684)
25b5688 
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
wyettzeng pushed a commit to wyettzeng/vllm that referenced this pull request Aug 21, 2026
@wangxiyuan @mergify @wyettzeng
[Misc] Remove override_attention_dtype (vllm-project#48684)
f4109c7 
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Wyett <wyettzeng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yewentao256 yewentao256 yewentao256 approved these changes
@claude claude[bot] claude[bot] left review comments
@hmellor hmellor Awaiting requested review from hmellor hmellor is a code owner
@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner
@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner
@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner
@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner
@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner
@houseroad houseroad Awaiting requested review from houseroad houseroad is a code owner
@ProExpertProg ProExpertProg Awaiting requested review from ProExpertProg ProExpertProg is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangxiyuan @yewentao256