[ROCm][Perf] Enable CSA multi-stream overlap for DeepSeek-V4 - #51794
Draft
shen-shanshan wants to merge 13 commits into
Draft
[ROCm][Perf] Enable CSA multi-stream overlap for DeepSeek-V4#51794shen-shanshan wants to merge 13 commits into
shen-shanshan wants to merge 13 commits into
Conversation
shen-shanshan
requested review from
dllehr-amd,
hongxiayang,
tjtanaa and
zyongye
as code owners
August 11, 2026 09:48
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
shen-shanshan
marked this pull request as draft
August 11, 2026 09:49
mergify
Bot
added
deepseek
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
shen-shanshan
force-pushed
the
rocm-dsv4-csa-multi-stream
branch
from
August 13, 2026 03:24
796108d to
5f88b24
Compare
shen-shanshan
force-pushed
the
rocm-dsv4-csa-multi-stream
branch
from
August 13, 2026 06:35
48e4031 to
06d206b
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
…ct#51430)" Restore the wider eager region because the narrowed capture corrupts ROCm output and regresses long-context serving performance. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com> Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
…roject#51768)" Restore Model Runner V1 after the prerequisite eager-region revert makes piecewise graph execution correct again and recovers ROCm decode throughput. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
shen-shanshan
force-pushed
the
rocm-dsv4-csa-multi-stream
branch
from
August 17, 2026 08:06
06d206b to
d314c00
Compare
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enable kernel-level multi-stream overlap for DeepSeek-V4 CSA (Compressed Sparse Attention, compress_ratio=4) attention layers on ROCm, gated by a new environment variable
VLLM_ROCM_DSV4_CSA_MULTI_STREAM(default off, serial fallback when unset). When enabled, the attention forward forks three HIP streams before the input GEMMs:After the join, the indexer weights GEMM, the indexer q-side (wq_b + fused q rope+quant), the sparse indexer op (top-k selection), and the MLA attention run serially on the main stream. Moving the two compressor wkv_gate GEMMs onto side streams takes them off the serial critical path; each stream runs a self-contained chain straight from
hidden_states, so no fine-grained cross-stream dependencies are required.Before:
After:
Test Plan
8k1kandagenticworkload.gsm8kdataset.Test Result
Benchmark (workload=8k1k tp8)
Benchmark (workload=agentic tp8)
To be completed...
Acc Test
To be completed...
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.