[CI/Build] Add warning for unsupported global PTX architecture requests in... - #51901
Conversation
… CMake configuration Co-authored-by: gemini-code-assist Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in PRs do not trigger a full CI run by default. Reviewers with write access and configured trusted contributors can comment Once the PR is approved or has the If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. Agent GuidelinesIMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban. 🚀 |
…cument CUDA architecture normalization behavior Co-authored-by: gemini-code-assist Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
|
Documentation preview: https://vllm--51901.org.readthedocs.build/en/51901/ |
mergify
Bot
added
documentation
Co-authored-by: gemini-code-assist Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
shanewidanagama
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| set(CUDA_ARCH_FLAGS "-gencode arch=compute_80,code=compute_80") | ||
| warn_if_ptx_arch_requested("${{CUDA_ARCH_FLAGS}}") | ||
|
|
||
| set(CUDA_ARCH_FLAGS "-gencode arch=compute_90a,code=[sm_90a,compute_90a]") | ||
| warn_if_ptx_arch_requested("${{CUDA_ARCH_FLAGS}}") |
There was a problem hiding this comment.
This case has two positive cases that will trigger the warning, but you are checking them as a whole.
BTW IMHO I do not think these tests make very much sense.
There was a problem hiding this comment.
Fair enough, the added overhead does not make testing for a warning worthwhile. I removed test_warn_if_ptx_arch_requested. Please take another look @Harry-Chen.
Co-authored-by: gemini-code-assist Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
Co-authored-by: gemini-code-assist Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
|
/ci run |
|
✅ @shanewidanagama, CI is now available for this PR.
|
|
Hi @shanewidanagama, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
|
Please fix the linter issues. Thanks! |
Signed-off-by: Shane Widanagama <46659817+shanewidanagama@users.noreply.github.com>
…newidanagama/vllm into cmake-cleanup-refactor-tasks
Head branch was pushed to by a user without write access
|
/ci retry |
|
✅ No earlier CI build exists for this PR. Use |
|
/ci run |
|
✅ Triggered Buildkite CI #83968 for commit |
|
/ci retry |
|
✅ The previous CI build is still running: https://buildkite.com/vllm/ci/builds/83968 |
|
Good evening @Harry-Chen, the buildkite CI appears to be failing for reasons other than the the PR changes. Please advise. |
…ts in... (vllm-project#51901) Signed-off-by: Alessandra005 <aurib032@fiu.edu>
…ts in... (vllm-project#51901) Signed-off-by: Wyett <wyettzeng@gmail.com>
3 participants
... CMake configuration.
Purpose
Implements one item from #9129: Warn that PTX builds are not currently supported (post [CI/Build] Per file CUDA Archs (improve wheel size and dev build times) #8845), currently if there is a +PTX in TORCH_CUDA_ARCH_LIST this will be ignored. We should warn when this is the case
Users can request PTX through
TORCH_CUDA_ARCH_LISTvalues such as8.0+PTX. vLLM strips the Torch-provided global-gencodeflags and rebuilds per-source gencode flags, so the global PTX request is not preserved. This PR surfaces that behavior during CMake configuration instead of silently dropping the request.This branch builds on PR #42375 by:
clear_cuda_archestoclear_cuda_gencode_flagsto clarify that it clears-gencodeflags fromCMAKE_CUDA_FLAGS, not the CUDA target architectures list itself.Changes
clear_cuda_arches()macro toclear_cuda_gencode_flags()in cmake/utils.cmake and CMakeLists.txt for clarity.warn_if_ptx_arch_requested()in cmake/utils.cmake and called it in CMakeLists.txt to warn users when PTX code generation is requested via global CUDA architecture flags.clear_cuda_gencode_flags().Test Plan
Tested behavior by:
VLLM_USE_PRECOMPILED=1 uv pip install -e .Test Result
1. CMake Utility Pytest Verification Output
2. Local Install Result
AI assistance disclosure
This PR description and code changes were prepared with AI assistance. The submitting contributor has reviewed every changed line and run the relevant validation tests.