[Bugfix] Temporarily disable FA4 head-dim 256 - #52050
Conversation
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
yewentao256
left a comment
There was a problem hiding this comment.
Thanks for the work! Also CC @MatthewBonanni
|
|
||
| def _mock_sm100_fa4(monkeypatch: pytest.MonkeyPatch) -> DeviceCapability: | ||
| import vllm.v1.attention.backends.fa_utils as fa_utils_mod | ||
| from vllm.vllm_flash_attn import flash_attn_interface |
There was a problem hiding this comment.
Will this import fail in Rocm?
There was a problem hiding this comment.
Good catch, fixed it.
|
✅ @taneem-ibrahim, CI is now available for this PR.
|
yewentao256
left a comment
There was a problem hiding this comment.
Could you also take a deeper look what is the root cause? I believe fixing accordingly would be better than fall back
Root cause is here where it explicitly has this as a TODO . # Keep parity with FlashAttentionForwardSm100.__call__ interface.
# (TODO@wangsiyu) Implement these features.
assert mSeqUsedQ is None and mSeqUsedK is None, (
"SM100 forward with head_dim=256 does not support seqused_q/seqused_k"
)We could wait until FA4 adds the support or do the fall back option for now. |
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
|
Ah thanks, I missed this when I landed #42669. Since this precludes its use for all decoders, I think we should just disable FA4 hdim 256 entirely until we can fix this upstream, rather than piping a new support argument through everything |
Thanks Matt! I will disable FA4 for head-dim 256 centrally. Just to confirm: should this disable FA4 head-dim 256 for encoder attention as well? |
|
i'll take a look at this |
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83975. |
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83975. |
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83975. |
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83975. |
|
/ci run |
|
✅ Triggered Buildkite CI #84037 for commit |
|
/ci run |
|
✅ Triggered Buildkite CI #84098 for commit |
…t#52050) Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Alessandra005 <aurib032@fiu.edu>
…m-project#52050)" This reverts commit 1f0e0bf. Signed-off-by: Simon Veitner <sveitner@redhat.com>
…m-project#52050)" This reverts commit 1f0e0bf. Signed-off-by: Simon Veitner <sveitner@redhat.com>
|
Upstream support is now proposed in Dao-AILab/flash-attention#2810. It implements Validation against the PR source on B300/SM103 covered paged decode with Linking here because this PR intentionally disabled the path pending an upstream fix. |
…t#52050) Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
…t#52050) Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Wyett <wyettzeng@gmail.com>
Purpose
PR #42669 enabled FA4 head-dim 256 on Blackwell, but the specialized SM100 2-CTA kernel still rejects
seqused_q/k, which vLLM decoder attention supplies. Temporarily resolve FA2 for head-dim 256 on Blackwell until upstream adds the required support. FA4 remains enabled for head-dim 128 and the supported MLA 192/128 case. ColPali under MRV2 exposed the failure (#48290).Reproducer
Output on main / on branch
Test Plan
AI assistance disclosure
OpenAI Codex (GPT-5) assisted with drafting the code. The submitter reviewed every changed line and ran the tests and model evaluation reported above.