-
-
Notifications
You must be signed in to change notification settings - Fork 21k
[Security] Fix ReDoS in validation error path sanitizer #52120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jperezdealgaba
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
jperezdealgaba:triage/GHSA-f2g9-sanitize-regex-dos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Severity: MEDIUM
The atomic group
(?>...)prevents exponential backtracking but still exhibits O(n²) behavior:re.subretries the pattern at every/-position, each time the atomic group scans the remaining input. Input like"/a" * 5000 + " error.txt"(dot bypasses the pre-check) takes ~9 seconds; at 50k segments it would block a worker for minutes. The original advisory PoC shape is only partially mitigated.Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Add a message length guard to the
ifcondition on line 319 to bound the O(n²) behavior. There.subretries the atomic-group pattern at every/-position, each scanning forward through the remaining input, creating quadratic time complexity. By capping the message length for this specific regex (e.g.,len(message) <= 2048), the worst-case time is bounded to ~30ms. Legitimate error messages with file paths are well under 2KB, and the preceding known-root-directory regex on lines 316-318 already handles common paths (/home/...,/usr/..., etc.) without this quadratic issue. Alternatively, for a more comprehensive fix, consider truncating the message at the top ofsanitize_message()(e.g.,message = message[:4096]) to protect all regexes in the function, or replace the regex with a linear-time token-based approach.