[Bugfix][MiniCPM-V] Fix AssertionError in get_dummy_mm_data when passing VideoDummyOptions to _get_dummy_images - #52122
Merged
DarkLight1337 merged 1 commit intoAug 13, 2026
Conversation
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
jikunshang
approved these changes
Aug 13, 2026
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83698 for commit |
DarkLight1337
approved these changes
Aug 13, 2026
DarkLight1337
enabled auto-merge (squash)
August 13, 2026 08:39
github-actions
Bot
added
the
ready
Member
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83698. |
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
…ing VideoDummyOptions to _get_dummy_images (vllm-project#52122) Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: pytest tests/lora/test_minicpmv_tp.py::test_minicpmv_lora raises AssertionError on non-CUDA platforms (e.g., XPU).
Root Cause:
Commit 9a276d6 added a runtime assertion to _get_dummy_images in dummy_inputs.py:
assert overrides is None or isinstance(overrides, ImageDummyOptions)
However, MiniCPMVDummyInputsBuilder.get_dummy_mm_data in minicpmv.py had always been passing video_overrides (type VideoDummyOptions) directly to _get_dummy_images when constructing per-frame dummy images for video. This type mismatch was silently ignored before the assertion was introduced.
Why upstream CI missed it: test_minicpmv_lora is decorated with @pytest.mark.skipif(current_platform.is_cuda_alike(), ...), so it is skipped entirely on CUDA CI.
Fix: In minicpmv.py, convert VideoDummyOptions before passing to _get_dummy_images: