[Doc] Fix group numbering in Case 3 of hybrid_kv_cache_manager.md - #52160
Merged
hmellor merged 1 commit intoAug 19, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Documentation preview: https://vllm--52160.org.readthedocs.build/en/52160/ |
Contributor
Author
|
Hi @hmellor! This is a small documentation fix for hybrid_kv_cache_manager.md — correcting the group numbering in Case 3. Could you take a look when you have a moment? Thanks! |
hmellor
reviewed
Aug 19, 2026
hmellor
left a comment
hmellor
left a comment
Member
There was a problem hiding this comment.
We are only saving one line with the ... let's just write all 6 groups explicitly
Contributor
Author
@hmellor, thanks for the quick review! You're right – using ... only saves one line and makes the grouping less clear. Will push the update in a moment. |
Explicitly list all groups (Group 0-6) instead of using '...' in the Case 3 example. With group_size=10, 52 sliding-window layers end at Group 5 (sw.50-51 + 8 padding); the doc previously misnumbered sw.40-49 as Group 6 and added a spurious Group 7. Now all groups are written out for clarity. Co-authored-by: deepseek-v4-flash Signed-off-by: qwerqwerqwe8688-jpg <xuuuuu2021@163.com>
qwerqwerqwe8688-jpg
force-pushed
the
docs/fix-hybrid-doc-group-numbering
branch
from
August 19, 2026 10:51
eb1f305 to
09dc0ef
Compare
hmellor
approved these changes
Aug 19, 2026
Member
|
/ci run |
hmellor
added
the
verified
|
✅ Triggered Buildkite CI #84590 for commit |
hmellor
enabled auto-merge (squash)
August 19, 2026 11:37
github-actions
Bot
added
the
ready
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
…lm-project#52160) Signed-off-by: qwerqwerqwe8688-jpg <xuuuuu2021@163.com>
wyettzeng
pushed a commit
to wyettzeng/vllm
that referenced
this pull request
Aug 21, 2026
…lm-project#52160) Signed-off-by: qwerqwerqwe8688-jpg <xuuuuu2021@163.com> Signed-off-by: Wyett <wyettzeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a self-inconsistent group numbering in
docs/design/hybrid_kv_cache_manager.mdCase 3 (lines 111-124).The doc says Gemma-3-27b has 52 sliding-window layers, but lists:
With group_size=10, 52 sw layers end at Group 6 (sw.50-51 + 8 padding); there is no Group 7. sw.40-49 belongs to Group 5.
Renumbered to: Group 5 = sw.40-49, Group 6 = sw.50-51 + 8 padding (7 groups total, Group 0-6).
Why not duplicating an existing PR
Searched
gh issue list/gh pr listfor "hybrid_kv_cache_manager": no open issue or PR. Pure documentation fix.Test Plan
Test Result
Local environment has no pre-commit/Python; relying on CI check.
AI Assistance
This PR was drafted with AI assistance; the human submitter reviewed every changed line. Co-authored-by: deepseek-v4-flash