Skip to content

[Bugfix] Disable sequence parallelism for Dots3 NOTE - #52172

Merged
youkaichao merged 1 commit into
vllm-project:mainfrom
KurodaKanbei:fix/dots3-note-sequence-parallel-init
Aug 13, 2026
Merged

[Bugfix] Disable sequence parallelism for Dots3 NOTE#52172
youkaichao merged 1 commit into
vllm-project:mainfrom
KurodaKanbei:fix/dots3-note-sequence-parallel-init

Conversation

@KurodaKanbei

Copy link
Copy Markdown
Contributor

Why

The DeepSeek V3.2 sequence-parallel refactor changed the inherited forward paths to use use_sequence_parallel.

Dots3 NOTE uses custom model and decoder initializers and has not adopted the new sequence-parallel execution path. This causes serving to fail during KV cache profiling with:

AttributeError: 'Dots3NoteModel' object has no attribute 'use_sequence_parallel'

What changed

Explicitly disable sequence parallelism for Dots3 NOTE and keep its existing non-SP execution path.

Validation

  • BF16 DP8 + EP + MTP3: startup and inference passed.
  • BF16 TP8 + EP + MTP3: startup and inference passed.
  • Text and image requests completed successfully.
  • No duplicate issue or PR was found.

Dots3 NOTE has not adopted the DeepSeek V3.2 sequence-parallel execution path. Explicitly opt it out so inherited forwards do not access missing state or use incompatible sharding.

Signed-off-by: KurodaKanbei <mistergalahad@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the bug Something isn't working label Aug 13, 2026
@youkaichao youkaichao added the verified Run pre-commit for new contributors without triggering other tests label Aug 13, 2026
@youkaichao
youkaichao merged commit 170592a into vllm-project:main Aug 13, 2026
14 of 16 checks passed
zyp2014 pushed a commit to zyp2014/vllm that referenced this pull request Aug 21, 2026
)

Signed-off-by: KurodaKanbei <mistergalahad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified Run pre-commit for new contributors without triggering other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants