[ROCm][CI] aiter kernel ops - enable rope test - #52854
Merged
Merged
Conversation
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
|
/ci run |
|
✅ Triggered Buildkite CI #84518 for commit |
Member
|
/ci run |
1 similar comment
Member
|
/ci run |
|
✅ Triggered Buildkite CI #84550 for commit |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #84619 for commit |
Contributor
Author
|
/ci run |
|
❌ @divakar-amd, A reviewer with write access must run |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #84921 for commit |
AndreasKaratzas
added
the
ready
|
✅ @divakar-amd, CI is now available for this PR.
|
AndreasKaratzas
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the
test_rocm_aiter_triton_rotary_embedding_vs_torchtest which was previously marked as xFail. The reason for difference in aiter kernel output and pytorch's reference implementation was because of intermediate dtype upcast to fp32. Aiter triton kernel preserves fp16 intermediate dtype. Hence, this PR removes the fp32 upcast from the reference impl.Additional comments - #52208 (comment)