[Bugfix][Compilation] Guard empty splitting ops before early return - #53061
Open
ActiveSky wants to merge 1 commit into
Open
[Bugfix][Compilation] Guard empty splitting ops before early return#53061ActiveSky wants to merge 1 commit into
ActiveSky wants to merge 1 commit into
Conversation
Apply the empty splitting_ops cudagraph fallback before returning for non-VLLM_COMPILE modes, keeping piecewise modes consistent with the available splitting operators. Fixes vllm-project#53030 Signed-off-by: jikuixie <jikuixie@gmail.com>
ActiveSky
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
August 20, 2026 06:44
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splitting_opscudagraph fallback before the early return for non-VLLM_COMPILEmodes.VLLM_COMPILEbehavior while sharing the downgrade logic.PIECEWISE -> NONEandFULL_AND_PIECEWISE -> FULL.Fixes #53030
Why this is not duplicate work
I checked issue #53030 and searched open pull requests for
53030,empty splitting_ops, andpiecewise cudagraph. No open PR addresses this early-return guard. The related results are separate cudagraph/spec-decode or documentation changes, not this configuration fix.Tests
VLLM_TARGET_DEVICE=cpu VLLM_USE_PRECOMPILED=1 .venv/bin/python -m pytest tests/compile/test_config.py -q -k empty_splitting_ops_disable_piecewise_cudagraphs --maxfail=1— 2 passed..venv/bin/ruff check vllm/config/compilation.py tests/compile/test_config.py— passed..venv/bin/ruff format --check vllm/config/compilation.py tests/compile/test_config.py— passed.GOPROXY=https://goproxy.cn,direct .venv/bin/pre-commit run --files vllm/config/compilation.py tests/compile/test_config.py— all applicable hooks passed.AI assistance
AI assistance was used to investigate the issue, implement the fix, and run the checks above. The human submitter must review every changed line and the test results before merging.