[CI] Add explicit Buildkite step keys to 7 keyless test-area steps - #53085
Draft
khluu wants to merge 1 commit into
Draft
[CI] Add explicit Buildkite step keys to 7 keyless test-area steps#53085khluu wants to merge 1 commit into
khluu wants to merge 1 commit into
Conversation
Steps without an explicit 'key:' get one derived from the label only during group conversion in the ci-infra pipeline generator, which runs after test-area candidacy for nightly trace enrollment is computed. These 7 plain-pytest steps (5 Rust Frontend E2E, MRCR Eval Small Models, Docker Build Metadata) are therefore silently invisible to any automation that matches steps by key at generation time. Keys follow the existing per-file conventions (rust-frontend-* as in rust_frontend_cargo.yaml, lm-eval-* as in lm_eval.yaml). No label, command, dependency, or device changes; note that adding key: changes the Buildkite step identity for these steps (label-keyed dashboards and automation are unaffected). Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Steps without an explicit
key:only get one derived from their label during group conversion in the ci-infra pipeline generator — which runs after test-area candidacy is computed for nightly trace enrollment (read_steps_from_job_dircollectsstep.keywhile keyless steps still havekey=None). These 7 plain-pytest steps are therefore silently invisible to key-based CI automation, including the nightly trace-instrumentation enrollment.What
Adds explicit
key:to the 7 affected steps — no label, command, dependency, timeout, or device changes:.buildkite/test_areas/rust_frontend.yaml(5):rust-frontend-openai-coverage,rust-frontend-serve-admin-coverage,rust-frontend-core-correctness,rust-frontend-tool-use,rust-frontend-distributed— following therust-frontend-*convention fromrust_frontend_cargo.yaml.buildkite/test_areas/lm_eval.yaml(1):lm-eval-mrcr-small-models— following thelm-eval-*convention.buildkite/test_areas/docker.yaml(1):docker-build-metadataNotes
key:changes the Buildkite step identity for these 7 steps (previously auto-derived from labels, e.g.-nvidia--h200-mrcr-eval-small-models). Label-keyed dashboards/automation are unaffected.Validation
Generator probe against this tree (ci-infra
configure_test_tracingon.buildkite/test_areas): all 7 keys are visible at candidacy time and enroll as traced jobs under the nightly path —docker-build-metadataandrust-frontend-distributedas python-only, the other five as kernel-set; none fall to always-run.