[ROCm][CI] Add float16 dtype and unsupported head size tests for paged attention - #53177
Merged
AndreasKaratzas merged 3 commits intoAug 21, 2026
Merged
Conversation
Add test_rocm_attention_head_sizes.py with tests for: - test_rocm_paged_attn_alibi - test_rocm_paged_attn_head_sizes - test_rocm_paged_attn_unsupported_head_sizes - test_triton_attn_decode_head_sizes These tests validate ROCm-specific attention kernel behavior for various head size configurations. Signed-off-by: Divakar Verma <divakar.verma@amd.com>
…alidation Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
divakar-amd
requested review from
AndreasKaratzas,
WoosukKwon,
mgoin,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 21, 2026 00:00
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
|
/ci run |
|
✅ Triggered Buildkite CI #84912 for commit |
AndreasKaratzas
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROCm paged attention kernel (csrc/rocm/attention.cu) only supports head sizes 64 and 128. This test ensures the kernel raises a clear RuntimeError("Unsupported head size") for other values rather than silently failing or producing incorrect results.