Revert "[Bugfix][MoE] Tune FlashInfer experts to scheduler token limit" (#52989) - #53186
Merged
Merged
Conversation
vllm-project#52989)" This reverts commit bfb6c13.
Member
|
cc @mgoin |
mgoin
marked this pull request as ready for review
August 21, 2026 18:25
mgoin
requested review from
AndreasKaratzas,
WoosukKwon,
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 21, 2026 18:25
Member
|
Let's just revert for now to avoid causing OOMs for users |
mgoin
approved these changes
Aug 21, 2026
|
✅ @vllm-agent, CI is now available for this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #52989 ("[Bugfix][MoE] Tune FlashInfer experts to scheduler token limit", merged as
bfb6c1349).Why
Nightly build #84887 (
bfb6c1349, the merge commit of #52989) turned:nvidia: (B200) LM Eval PCPred for the first time. That job was green in the previous four nightlies (84473, 84555, 84687, 84753).evals/gsm8k/test_gsm8k_correctness.py::test_gsm8k_correctness[GLM-5.2-NVFP4-TP2-PCP2-EP]now dies withServer exited unexpectedly.; every one of the four workers raises:Line 368 is the
flashinfer_cutlass_fused_moe(...)call this PR modified. The job runs withmax_num_batched_tokens=32768, sofi_moe_largest_bucket()returnsmax(32768 * dp_size, 8192)and the FlashInfer CUTLASS autotune bucket jumps 8192 -> 32768, quadrupling the workspacegetWorkspaceInforeserves.fi_moe_largest_bucket's own docstring warns that "overestimation may be dangerous, increasing tuning-cost and memory use" and that PCP is not modelled by the estimate — which is exactly the configuration that broke. The siblingGLM-5.2-NVFP4-TP1-PCP4-EPconfig, which has a smaller per-rank footprint, still passes (0.9325).Related: open issue #51071 tracks earlier OOMs in this job.
Note for reviewers
This is a draft. The underlying autotune-coverage problem #52989 set out to fix is real; a narrower fix that caps the tuned bucket (or accounts for PCP/EP memory headroom) would be preferable to this revert. Reverting is proposed only to get the B200 PCP eval green while that fix is prepared. The revert applied cleanly with no conflicts and is an exact inverse of the original diff (6 files, 1 insertion, 12 deletions).
Auto-generated by CI failure analyzer.