Skip to content

Revert "Remove native Hunyuan V1 and VL implementations" - #53296

Merged
vllm-bot merged 2 commits into
vllm-project:mainfrom
khluu:revert-hunyuan-native-removal
Aug 21, 2026
Merged

Revert "Remove native Hunyuan V1 and VL implementations"#53296
vllm-bot merged 2 commits into
vllm-project:mainfrom
khluu:revert-hunyuan-native-removal

Conversation

@khluu

@khluu khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member

Why

This reverts #53272 because it deterministically breaks the CPU Multimodal Processor test matrix after switching HunyuanOCR to the Transformers HunYuanVLProcessor:

ValueError: HunYuanVL image placeholders must be formatted as
<|hy_place▁holder▁no▁100|><|hy_place▁holder▁no▁102|><|hy_place▁holder▁no▁101|>

The merged commit d53b1c2e is the first affected main commit. Main Buildkite #85049 fails CPU Multimodal Processor shards 1 and 4 in three HunyuanOCR test_processing_correctness cases.

The exact PR-head Buildkite #85016 selected all four CPU Multimodal Processor shards and failed the identical HunyuanOCR cases in shards 1 and 4 while shards 2 and 3 passed. This is deterministic code evidence rather than runner noise.

Duplicate-work check

Searched open PRs for 53272, HunyuanOCR placeholder processor, and revert Hunyuan native removal; no existing revert or equivalent fix was found.

Validation

  • git diff HEAD^ --check
  • Verified this commit is the exact inverse of merge commit d53b1c2e with git apply --check --reverse
  • Signed-head Buildkite #85060 at exact commit 6a5bbcbad020a062572c06344c523dae107ac3f6: CPU Multimodal Processor shard 1 passed on ip-10-0-34-197 at 17:43:16 UTC and shard 4 passed on ip-10-0-4-137 at 17:39:47 UTC
  • Build #85060 is red only because the branch also encounters the independent open [ROCm][Perf] Kimi-K3 Fused kernels for KDA prefill #52606 Kimi AMD image regression; both required CPU gates passed

No model evaluation is applicable because this is an emergency rollback restoring the implementation and test behavior present immediately before the breaking merge.

Merge gate

Keep this draft until human line-by-line review. The incident remains open after pre-merge validation and closes only after merge plus exact post-merge main CPU Multimodal shards 1 and 4 pass.

AI assistance

AI assistance was used to investigate the CI failure, prepare the revert, and draft this PR. The human submitter must review every changed line and can explain and defend the change end-to-end.

@khluu

khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ci run

@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--53296.org.readthedocs.build/en/53296/

@mergify mergify Bot added documentation Improvements or additions to documentation new-model Requests to new models labels Aug 21, 2026
…#53272)"

This reverts commit d53b1c2.

Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
@khluu
khluu force-pushed the revert-hunyuan-native-removal branch from 5b4d4aa to 6a5bbcb Compare August 21, 2026 17:01
@khluu

khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #85060 for commit 6a5bbcbad020.

@github-actions

Copy link
Copy Markdown

✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/85060

@khluu

khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Signed-head exact run is Buildkite #85060. CPU Multimodal Processor shards 1 and 4 are selected and currently waiting behind image prerequisites; awaiting terminal results.

@DarkLight1337

Copy link
Copy Markdown
Member

Shouldn't we just remove the tests that depend on the removed model?

@khluu

khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Partial signed-head result: Buildkite #85060 CPU Multimodal Processor shard 4 passed at exact head 6a5bbcbad020a062572c06344c523dae107ac3f6; shard 1 remains running. The branch AMD image failures are the independent open #52606 Kimi regression and do not block the CPU validation gate.

@khluu

khluu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Strict signed-head validation is complete: Buildkite #85060 ran at exact commit 6a5bbcbad020a062572c06344c523dae107ac3f6. CPU Multimodal Processor shard 1 passed on ip-10-0-34-197 at 17:43:16 UTC, and shard 4 passed on ip-10-0-4-137 at 17:39:47 UTC. These are the two shards that deterministically failed the HunyuanOCR placeholder cases on main #85049 and culprit PR-head #85016. Build #85060 is red only because this branch also sees the independent open #52606 Kimi AMD image regression; the required CPU revert gate is green. Keep the incident open until human review/merge plus exact post-merge main confirmation.

@njhill
njhill marked this pull request as ready for review August 21, 2026 20:36

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@AndreasKaratzas

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #85108 for commit f353de1221cd.

@vllm-bot
vllm-bot merged commit e3f6026 into vllm-project:main Aug 21, 2026
7 of 9 checks passed
@njhill

njhill commented Aug 21, 2026

Copy link
Copy Markdown
Member

@DarkLight1337 agree usually but so many things were breaking we just need to stabilize CI urgently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new-model Requests to new models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants