Skip to content

Fix ArchiveTimestampSequence definition - #232

Open
arkkors wants to merge 1 commit into
wbond:masterfrom
arkkors:fix-evidence-record-definition
Open

Fix ArchiveTimestampSequence definition#232
arkkors wants to merge 1 commit into
wbond:masterfrom
arkkors:fix-evidence-record-definition

Conversation

@arkkors

@arkkors arkkors commented Jun 4, 2022

Copy link
Copy Markdown

RFC4998, Section 5.1 defines the ArchiveTimestampSequence as:

ArchiveTimeStampChain    ::= SEQUENCE OF ArchiveTimeStamp
ArchiveTimeStampSequence ::= SEQUENCE OF ArchiveTimeStampChain

asn1crypto.tsp defines ArchiveTimeStampSequence as:

class ArchiveTimeStampSequence(SequenceOf):
   _child_spec = ArchiveTimeStamp

and ArchiveTimeStampChain is absent.

This MR fixes the issue.

@arkkors arkkors changed the title Fix evidence record definition Fix ArchiveTimestampSequence definition Jun 4, 2022
@wbond

wbond commented Jun 28, 2022

Copy link
Copy Markdown
Owner

Thanks for catching this.

Do you have an example file we could add as a fixture to test this with?

@wbond

wbond commented Oct 17, 2022

Copy link
Copy Markdown
Owner

Pinging you @arkkors to see if you have a test file we could use for this?

@arkkors

arkkors commented Oct 17, 2022

Copy link
Copy Markdown
Author

Sorry, lost track of that.

I myself don't have test files right now. However there is this repo here: https://github.com/de-bund-bsi-tr-esor/ERVerifyTool
In particular this file looks usable: https://github.com/de-bund-bsi-tr-esor/ERVerifyTool/blob/master/test/1.RFC4998-bin-data_er/BIN_ER.ers

Does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants