Properly serialize postgres array columns - #82
Merged
Conversation
…veSnapshot::Snapshot::PG error
westonganger
left a comment
westonganger
left a comment
Owner
There was a problem hiding this comment.
Some comments/questions that I will wait for you to respond to, but other than that this looks good. Thanks.
Contributor
Author
|
@westonganger I addressed your comments if you want to take a look |
Owner
|
Merged. Thanks for your contribution! |
westonganger
changed the title
Owner
|
v1.2.1 is now released which contains this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug with a PG enum array column: for those,
attributes_for_databasereturn a struct:which got serialized by
build_snapshot_itemas:It should just serialize the values as a standard array:
["XS","S"]The PR includes a test to catch that bug, and I tried to keep the fix as minimal as possible, hope this looks good but if not feel free to suggest changes !