Introduce handler resolver - #327
Open
vjik wants to merge 10 commits into
Open
Conversation
vjik
commented
Aug 14, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
============================================
- Coverage 92.51% 92.42% -0.09%
- Complexity 379 382 +3
============================================
Files 55 59 +4
Lines 988 1017 +29
============================================
+ Hits 914 940 +26
- Misses 74 77 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samdark
reviewed
Aug 17, 2026
Comment on lines
74
to
77
|
|
||
| if (is_callable($definition)) { | ||
| return $definition; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
Duplicates the new check on line 40
Member
Author
There was a problem hiding this comment.
CallableFactory is used in MiddlewareFactory also. Left for future refactoring.
Member
There was a problem hiding this comment.
@vjik the same check is at line 40 already so this one is not reachable, it seems.
samdark
reviewed
Aug 30, 2026
samdark
reviewed
Aug 31, 2026
| } | ||
| } | ||
|
|
||
| public function testHandlerNotFoundInContainer(): void |
Member
There was a problem hiding this comment.
Is it tested in a different way now?
| $worker->process($message, $queueName); | ||
| } | ||
|
|
||
| public function testHandlerInContainerNotImplementingInterface(): void |
Member
There was a problem hiding this comment.
Is it tested in a different way now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.