Fix Dagstuhl PDF saving - #3476
Merged
AbeJellinek merged 1 commit intoAug 8, 2025
Merged
Conversation
Contributor
Author
|
@AbeJellinek, I see the connector test page load is failing, and for a while (looking at the Actions history). Not sure what exactly is the reason, but can dig in, need any help here? If yes, any pointers or ideas are more than welcome. |
While at it, asyncify, modernize, and align formatting. Fixes zotero#3475. Signed-off-by: Alex T. <frozen.and.blue@gmail.com>
alex-ter
force-pushed
the
gh3475-fix-dagstuhl-pdf-saving
branch
from
July 26, 2025 16:29
2068177 to
6db7929
Compare
Contributor
Author
|
...and your commit c089bf1 has fixed it indeed. Thanks a lot! |
Contributor
Author
|
@AbeJellinek, as the tests are passing, is there anything else holding this one up? |
Member
|
Nothing! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While at it, asyncify, modernize, and align formatting.
Tested using existing tests (which passed with the bug, BTW) and using additional debug output.
Fixes #3475.