Update NASA ADS translator to support new app scixplorer.org - #3479
Merged
Conversation
shinyichen
marked this pull request as ready for review
July 28, 2025 17:52
AbeJellinek
requested changes
Jul 29, 2025
AbeJellinek
left a comment
AbeJellinek
left a comment
Member
There was a problem hiding this comment.
Thanks! A few comments. Non-lint-related test failures are false negatives - something is wrong with multiples... I'll figure that out.
Member
|
Actually not false negatives. The translator detects |
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am with ADS, we are updating the NASA ADS translator to support the new app scixplorer.org