Constrain Agent Hook autofix reminders to exact reviews

[mariusvniekerk]

Agent Hook reminders could repeatedly rediscover the same failed reviews and turn background feedback into unrelated repair work. The default fallback could also start a separate fix agent that had no reliable view of the user's active task.

Reminders now name the exact review jobs they surfaced and invoke only the bundled roborev-fix skill. The skill treats findings as claims to prove against current code: it fixes valid in-scope problems, closes invalid reviews with evidence and no code change, and leaves valid out-of-scope work open for the user. Customized instructions remain complete overrides.

Delivered job IDs are remembered per agent session and repository lineage so later hook events do not reopen the same loop; newly created jobs remain eligible. Observation stays best-effort because post-tool hooks run frequently. Hook installation also refreshes bundled skills for Claude Code, Codex, Factory Droid, and Grok Build. Profiles without a bundled variant deliberately receive no generic CLI fallback.

^{generated by a clanker}

[roborev-ci]

roborev: Combined Review (b22fe79)

The changes need revision due to two medium-severity workflow issues.

Medium

• Unavailable fix workflow for several hook profiles — internal/config/config.go:657
  Every hook profile is instructed to invoke roborev-fix, but that skill is installed only for Claude, Codex, Droid, and Grok. Copilot, Cursor, Gemini, Hermes, and Qwen receive an unavailable workflow without a CLI fallback, after which the review IDs are acknowledged and will not be surfaced again.
  Fix: Provide an exact-ID CLI workflow for profiles without bundled skills, or add compatible skill variants before enabling the instruction by default.

• Legacy reminders retain the broad discovery command — internal/agenthook/state.go:824
  Deferred reminders without a persisted Instruction retain their previous Reason, which may include the old roborev fix --open --list workflow. Appending exact review IDs does not remove that broad command, so reminders queued before upgrading can still exceed the current task scope.
  Fix: Detect and replace the former built-in instruction during migration while preserving custom reasons, or safely discard legacy built-in reminders.

---

Reviewers: 2 done | Synthesis: codex, 10s | Total: 5m9s

[roborev-ci]

roborev: Combined Review (471d833)

Code review found one medium-severity issue that could re-emit acknowledged reviews.

Medium

• internal/agenthook/state.go:415 — Acknowledged review IDs are filtered before the final lineage key is determined. Detached-to-branch amend/rewrite handling may subsequently restore the prior lineage, causing already acknowledged reviews to be emitted again.
  • Fix: Compute actionableReviewIDs and failedReviewCount only after all lineage-key adjustments are complete.

---

Reviewers: 2 done | Synthesis: codex, 10s | Total: 5m36s

[roborev-ci]

roborev: Combined Review (aa88918)

Review requires changes: one medium-severity compatibility issue affects several supported agent profiles.

Medium

• Unavailable roborev-fix skill for supported profiles — internal/config/config.go:657, internal/agenthook/install.go:150
  The default instruction requires roborev-fix for every supported profile, but installation provides it only for Claude, Codex, Droid, and Grok. Fresh Copilot, Gemini, Hermes, Qwen, and Cursor installations receive reminders invoking an unavailable skill without an actionable CLI fallback. Provide bundled skills for every profile, or use a scoped exact-ID CLI fallback for profiles without skill support.

---

Reviewers: 2 done | Synthesis: codex, 9s | Total: 5m52s

[mariusvniekerk]

The CLI Fallback is rejected since its a bad idea.

[roborev-ci]

roborev: Combined Review (02f1fe0)

Upgrade migration is incomplete, leaving existing configs with outdated instructions.

Medium

• internal/config/config.go:669 — Existing generated configs retain the previous default instruction, so upgraded profiles—especially those without bundled skills—continue allowing roborev fix --open --list. Migrate exact historical defaults in both hook config sections to the new default while preserving custom values.

---

Reviewers: 2 done | Synthesis: codex, 5s | Total: 5m27s

[roborev-ci]

roborev: Combined Review (d3d8224)

Code is generally sound, but one compatibility gap remains for several hook profiles.

Medium

• internal/config/config.go:670 — The default reminder requires roborev-fix, but Copilot, Cursor, Gemini, Hermes, and Qwen receive neither that bundled skill nor the previous CLI fallback. Their installed hooks therefore suggest a workflow they cannot execute. Provide a scope-safe exact-ID CLI fallback or install a compatible skill for every supported profile.

---

Reviewers: 2 done | Synthesis: codex, 11s | Total: 2m49s

[roborev-ci]

roborev: Combined Review (56a193d)

Code is generally sound, but rerun failures can be incorrectly suppressed.

Medium

• internal/agenthook/state.go:1210 — Acknowledgements are keyed only by job ID. Because reruns reuse that ID while replacing the review output, a newly failed rerun is suppressed for the session and lineage. Key acknowledgements by review generation (for example, job ID plus FinishedAt or UpdatedAt) and test that failed reruns prompt again.

---

Reviewers: 2 done | Synthesis: codex, 5s | Total: 4m29s

[roborev-ci]

roborev: Combined Review (0a4c785)

Code is generally sound, but rerun failures can be incorrectly suppressed after acknowledgment.

Medium

• internal/agenthook/state.go:1240 — Acknowledgments are keyed only by job ID, which is reused across reruns. After a failure is acknowledged, subsequent failed reruns remain suppressed for the session. Track acknowledgment by attempt identity, such as job ID plus review ID or completion timestamp.

---

Reviewers: 2 done | Synthesis: codex, 8s | Total: 3m51s