Skip to content

put .profraw files into a dedicated directory under "build" - #66

Merged
yuvalif merged 1 commit into
lancedb:mainfrom
yuvalif:hide-coverage-files
Aug 11, 2026
Merged

put .profraw files into a dedicated directory under "build"#66
yuvalif merged 1 commit into
lancedb:mainfrom
yuvalif:hide-coverage-files

Conversation

@yuvalif

@yuvalif yuvalif commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the CMake-driven Rust build commands to direct LLVM coverage .profraw output into a dedicated directory under the build directory, aiming to keep profiling artifacts better organized during coverage builds.

Changes:

  • Adds an LLVM_PROFILE_FILE=... environment variable to the Rust cargo build command when BUILD_COVERAGE is enabled.
  • Reuses the same profiling environment when building the external_provider helper crate under examples.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CMakeLists.txt
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@yuvalif
yuvalif merged commit a806cea into lancedb:main Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants