Skip to content

put .profraw files into a dedicated directory under "build" #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuvalif merged 1 commit into from
Aug 11, 2026
Merged

put .profraw files into a dedicated directory under "build" #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,12 @@ configure_file(lancedb.pc.in "${CMAKE_BINARY_DIR}/lancedb.pc" @ONLY)
set(CARGO_BUILD_COMMAND cargo build ${RUST_BUILD_TYPE} ${RUST_TARGET_OPT} --target-dir "${CMAKE_BINARY_DIR}/target")
if(BUILD_COVERAGE)
set(PROFRAW_DIR "${CMAKE_BINARY_DIR}/profraw")
set(BUILD_PROFRAW_DIR "${PROFRAW_DIR}/build")
file(MAKE_DIRECTORY "${PROFRAW_DIR}" "${BUILD_PROFRAW_DIR}")
set(BUILD_PROFRAW_ENV "LLVM_PROFILE_FILE=${BUILD_PROFRAW_DIR}/%p_%m.profraw")
# Use CARGO_ENCODED_RUSTFLAGS (0x1f-separated) instead of RUSTFLAGS
# so that Cargo includes it in its fingerprint and triggers a rebuild
set(CARGO_BUILD_COMMAND ${CMAKE_COMMAND} -E env "CARGO_ENCODED_RUSTFLAGS=-Cinstrument-coverage" ${CARGO_BUILD_COMMAND})
set(CARGO_BUILD_COMMAND ${CMAKE_COMMAND} -E env "CARGO_ENCODED_RUSTFLAGS=-Cinstrument-coverage" "${BUILD_PROFRAW_ENV}" ${CARGO_BUILD_COMMAND})
Comment thread
yuvalif marked this conversation as resolved.
endif()
add_custom_target(rust-lib ALL
COMMAND ${CARGO_BUILD_COMMAND}
Expand Down Expand Up @@ -215,7 +218,7 @@ if(BUILD_EXAMPLES)
# external_provider helper crate (provides external_object_store_provider_create)
set(EXT_PROVIDER_CARGO_CMD cargo build ${RUST_BUILD_TYPE} ${RUST_TARGET_OPT} --target-dir "${CMAKE_BINARY_DIR}/target")
if(BUILD_COVERAGE)
set(EXT_PROVIDER_CARGO_CMD ${CMAKE_COMMAND} -E env "CARGO_ENCODED_RUSTFLAGS=-Cinstrument-coverage" ${EXT_PROVIDER_CARGO_CMD})
set(EXT_PROVIDER_CARGO_CMD ${CMAKE_COMMAND} -E env "CARGO_ENCODED_RUSTFLAGS=-Cinstrument-coverage" "${BUILD_PROFRAW_ENV}" ${EXT_PROVIDER_CARGO_CMD})
endif()
if(WIN32)
set(EXT_PROVIDER_SHARED_PATH "${RUST_TARGET_DIR}/lancedb_external_provider${CMAKE_SHARED_LIBRARY_SUFFIX}")
Expand Down
Loading