Revert "[Bugfix] Guard DeepSeek V4 MRV1 piecewise CUDA graphs" (#51768) - #52094
Closed
Fangzhou-Ai wants to merge 2 commits into
Closed
Revert "[Bugfix] Guard DeepSeek V4 MRV1 piecewise CUDA graphs" (#51768)#52094Fangzhou-Ai wants to merge 2 commits into
Fangzhou-Ai wants to merge 2 commits into
Conversation
…ct#51430)" Restore the wider eager region because the narrowed capture corrupts ROCm output and regresses long-context serving performance. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
…roject#51768)" Restore Model Runner V1 after the prerequisite eager-region revert makes piecewise graph execution correct again and recovers ROCm decode throughput. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
Fangzhou-Ai
requested review from
ProExpertProg,
WoosukKwon,
dllehr-amd,
hongxiayang,
houseroad,
mgoin,
robertgshaw2-redhat,
tjtanaa,
tlrmchlsmth,
yewentao256,
youkaichao and
zyongye
as code owners
August 13, 2026 04:07
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mergify
Bot
added
deepseek
4 tasks
Collaborator
|
Sorry for introducing the regression. Do we understand why the regression happens though? We are deprecating MRv1 anyways, so MRV2 should be working well on AMD. |
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
Stacked on #52093. Do not merge this PR first: reverting #51768 alone would re-enable the known-broken MRV1 piecewise path while #51430 remains active. Until #52093 merges, this PR intentionally contains both revert commits; afterward its diff reduces to the config/test revert.
Why
On gfx950 TP8, MRV2 preserved correctness but regressed steady decode performance. With the prerequisite eager-region revert, MRV1 piecewise execution is correct and restores long-context throughput.
No open PR reverting #51768 was found.
Test plan
Configuration: DeepSeek-V4-Pro, gfx950, TP=8, DP=1, prefix caching disabled,
max_num_batched_tokens=8192, AITER MoE, FP8 KV cache,FULL_AND_PIECEWISEgraphs.Additional results:
1 + 1returned2.Pre-commit hooks run during commit passed, including Ruff, formatting, mypy, SPDX, and configuration validation.
Contribution notes