Revert "[Perf] Narrow DeepSeek V4 eager CUDA graph region" (#51430) - #52093
Closed
Fangzhou-Ai wants to merge 1 commit into
Closed
Revert "[Perf] Narrow DeepSeek V4 eager CUDA graph region" (#51430)#52093Fangzhou-Ai wants to merge 1 commit into
Fangzhou-Ai wants to merge 1 commit into
Conversation
…ct#51430)" Restore the wider eager region because the narrowed capture corrupts ROCm output and regresses long-context serving performance. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
Fangzhou-Ai
requested review from
dllehr-amd,
hongxiayang,
tjtanaa and
zyongye
as code owners
August 13, 2026 04:06
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
|
/ci run |
|
✅ Triggered Buildkite CI #83668 for commit |
4 tasks
Member
|
We are planning to address this via #52401 instead. |
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fused_wqa_wkv_gemmoverride point while resolving the revert against current main.Why
On gfx950 TP8, the narrowed eager region corrupts output under the MRV1 piecewise graph path. MRV2 avoids that corruption but regresses 8k/1k concurrency-4 throughput. Restoring the wider eager region makes the legacy path correct and recovers the attention performance needed by the follow-up runner revert.
This revisits closed PR #51750 with new ROCm correctness and performance measurements. No open PR currently reverts #51430.
Test plan
Configuration: DeepSeek-V4-Pro, gfx950, TP=8, DP=1, prefix caching disabled,
max_num_batched_tokens=8192, AITER MoE, FP8 KV cache,FULL_AND_PIECEWISEgraphs.Combined with the stacked #51768 revert:
1 + 1returned2.Pre-commit hooks run during commit passed, including Ruff, formatting, mypy, SPDX, and configuration validation.
Contribution notes