Remove SDF polygon clipping from Globe - #13638
Open
mzschwartz5 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 20, 2026
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
July 21, 2026 17:31
28c14d6 to
6fb2a70
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 21, 2026 17:31
6b7cd31 to
0d13561
Compare
This was referenced Jul 21, 2026
8 tasks
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
July 29, 2026 18:55
6fb2a70 to
9953e6b
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 29, 2026 18:56
0d13561 to
faef7cf
Compare
mzschwartz5
marked this pull request as ready for review
July 30, 2026 15:43
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 30, 2026 22:21
faef7cf to
4764eef
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
July 31, 2026 16:57
1704714 to
c8346e0
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 16:57
4764eef to
41fea28
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
July 31, 2026 18:55
c8346e0 to
4b3bd7d
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 18:55
41fea28 to
c6cd277
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
July 31, 2026 22:25
4b3bd7d to
512656d
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 22:25
c6cd277 to
86820f6
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 3, 2026 01:07
512656d to
453391f
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 01:07
86820f6 to
b3d194c
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 3, 2026 01:14
453391f to
27cbc04
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 01:14
b3d194c to
3a8628b
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 3, 2026 19:32
27cbc04 to
027db9d
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 19:32
3a8628b to
2b5215d
Compare
8 tasks
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 10, 2026 19:39
027db9d to
455e445
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 10, 2026 19:39
2b5215d to
1b750d4
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 18, 2026 17:20
455e445 to
4430325
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 18, 2026 17:20
1b750d4 to
bd076d8
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 19, 2026 17:08
4430325 to
01ee56a
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 19, 2026 17:08
bd076d8 to
34a3f83
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 19, 2026 19:38
01ee56a to
fe9d895
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 19, 2026 19:38
34a3f83 to
6635d0d
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 20, 2026 14:17
fe9d895 to
6386ffa
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 20, 2026 14:17
6635d0d to
05ee4c7
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 20, 2026 14:33
6386ffa to
b1d302e
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 20, 2026 14:33
05ee4c7 to
63f2394
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 21, 2026 16:14
b1d302e to
7f92ee6
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 21, 2026 16:14
63f2394 to
ce89cf6
Compare
mzschwartz5
force-pushed
the
clipping-globe-shader-rework
branch
from
August 21, 2026 16:16
7f92ee6 to
1a42e12
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 21, 2026 16:16
ce89cf6 to
a8f1d7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply removes now-unused code from the Globe classes / shaders related to SDF-based polygon clipping (since down-stack PRs have reimplemented Globe polygon clipping on the vector pipeline).
Issue number and link
None
Testing plan
Regression testing -- follow same testing plan as in #13637
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):
PR Dependency Tree
This tree was auto-generated by Charcoal