Skip to content

Remove SDF polygon clipping from Globe - #13638

Open
mzschwartz5 wants to merge 1 commit into
clipping-globe-shader-reworkfrom
remove-old-terrain-clipping-details
Open

Remove SDF polygon clipping from Globe#13638
mzschwartz5 wants to merge 1 commit into
clipping-globe-shader-reworkfrom
remove-old-terrain-clipping-details

Conversation

@mzschwartz5

@mzschwartz5 mzschwartz5 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR simply removes now-unused code from the Globe classes / shaders related to SDF-based polygon clipping (since down-stack PRs have reimplemented Globe polygon clipping on the vector pipeline).

Issue number and link

None

Testing plan

Regression testing -- follow same testing plan as in #13637

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

PR Dependency Tree

This tree was auto-generated by Charcoal

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @mzschwartz5!

✅ We can confirm we have a CLA on file for you.

@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 28c14d6 to 6fb2a70 Compare July 21, 2026 17:31
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 6b7cd31 to 0d13561 Compare July 21, 2026 17:31
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 6fb2a70 to 9953e6b Compare July 29, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 0d13561 to faef7cf Compare July 29, 2026 18:56
@mzschwartz5
mzschwartz5 marked this pull request as ready for review July 30, 2026 15:43
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from faef7cf to 4764eef Compare July 30, 2026 22:21
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 1704714 to c8346e0 Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 4764eef to 41fea28 Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from c8346e0 to 4b3bd7d Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 41fea28 to c6cd277 Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 4b3bd7d to 512656d Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from c6cd277 to 86820f6 Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 512656d to 453391f Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 86820f6 to b3d194c Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 453391f to 27cbc04 Compare August 3, 2026 01:14
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from b3d194c to 3a8628b Compare August 3, 2026 01:14
@mzschwartz5 mzschwartz5 mentioned this pull request Aug 3, 2026
8 tasks
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 27cbc04 to 027db9d Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 3a8628b to 2b5215d Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 requested a review from donmccurdy August 5, 2026 15:56
@mzschwartz5
mzschwartz5 requested a review from danielzhong August 5, 2026 15:57
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 027db9d to 455e445 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 2b5215d to 1b750d4 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 455e445 to 4430325 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 1b750d4 to bd076d8 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 4430325 to 01ee56a Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from bd076d8 to 34a3f83 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 01ee56a to fe9d895 Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 34a3f83 to 6635d0d Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from fe9d895 to 6386ffa Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 6635d0d to 05ee4c7 Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 6386ffa to b1d302e Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 05ee4c7 to 63f2394 Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from b1d302e to 7f92ee6 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 63f2394 to ce89cf6 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the clipping-globe-shader-rework branch from 7f92ee6 to 1a42e12 Compare August 21, 2026 16:16
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from ce89cf6 to a8f1d7f Compare August 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant