Skip to content

Remove polygon clipping sdf path - #13654

Open
mzschwartz5 wants to merge 8 commits into
model-clipping-pipeline-wiringfrom
remove-polygon-clipping-sdf-path
Open

Remove polygon clipping sdf path#13654
mzschwartz5 wants to merge 8 commits into
model-clipping-pipeline-wiringfrom
remove-polygon-clipping-sdf-path

Conversation

@mzschwartz5

@mzschwartz5 mzschwartz5 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes the dead code paths and files previously used by clipping polygons for SDF-based clipping. It adds deprecation warnings for the quality and debugShowDistanceTexture properties of ClippingPolygonCollection, as those fields no longer have meaning with the new implementation (and have been replaced with no-ops). It also adds deprecations for the destroy functions of ClippingPolygonCollection, as the collection itself no longer owns any GPU resources to be destroyed.

Love to see it! (and those additions are mostly regarding the deprecation warnings!)
image

Issue number and link

TODO

Testing plan

Regression testing + following the testing plan of #13647

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

PR Dependency Tree

This tree was auto-generated by Charcoal

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @mzschwartz5!

✅ We can confirm we have a CLA on file for you.

@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch 2 times, most recently from 3d358b8 to b84a07a Compare July 29, 2026 21:14
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch 2 times, most recently from 0fd0dba to 9c8e913 Compare July 29, 2026 21:44
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from b84a07a to 59dc559 Compare July 30, 2026 18:22
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 9c8e913 to ad16e0d Compare July 30, 2026 18:24
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 59dc559 to 6d13de2 Compare July 30, 2026 22:21
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from ad16e0d to 9c63bc6 Compare July 30, 2026 22:21
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 6d13de2 to 7d28e27 Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 9c63bc6 to 6ffad4f Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 7d28e27 to 8e571dc Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 6ffad4f to 8590425 Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 8e571dc to 7e33e73 Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 8590425 to a9ae3c0 Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 7e33e73 to 2300e23 Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from a9ae3c0 to 562662d Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 2300e23 to d9b3232 Compare August 3, 2026 01:14
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 562662d to 1488f9c Compare August 3, 2026 01:14
@mzschwartz5
mzschwartz5 marked this pull request as ready for review August 3, 2026 02:03
@mzschwartz5 mzschwartz5 mentioned this pull request Aug 3, 2026
8 tasks
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from d9b3232 to 400740e Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 1488f9c to a32f062 Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 400740e to 9d74f09 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from a32f062 to 28f2e58 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 9d74f09 to a33ee73 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 28f2e58 to 8160451 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from a33ee73 to 96fb786 Compare August 18, 2026 17:28
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 8160451 to feb488c Compare August 18, 2026 17:28
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 96fb786 to 33c9864 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from feb488c to 0aee935 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 33c9864 to ed8db86 Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 0aee935 to b6c2e9b Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from ed8db86 to 386c5ae Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from fc6ecd5 to 6d99067 Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 386c5ae to 07657ce Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 6d99067 to 0b183ea Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from 07657ce to c3424c2 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 0b183ea to 333c1db Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-pipeline-wiring branch from c3424c2 to 33c58e4 Compare August 21, 2026 16:16
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 333c1db to 7dc4085 Compare August 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant