Remove polygon clipping sdf path - #13654
Open
mzschwartz5 wants to merge 8 commits into
Open
Conversation
This was referenced Jul 28, 2026
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
2 times, most recently
from
July 29, 2026 21:14
3d358b8 to
b84a07a
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
2 times, most recently
from
July 29, 2026 21:44
0fd0dba to
9c8e913
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
July 30, 2026 18:22
b84a07a to
59dc559
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
July 30, 2026 18:24
9c8e913 to
ad16e0d
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
July 30, 2026 22:21
59dc559 to
6d13de2
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
July 30, 2026 22:21
ad16e0d to
9c63bc6
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
July 31, 2026 16:57
6d13de2 to
7d28e27
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
July 31, 2026 16:57
9c63bc6 to
6ffad4f
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
July 31, 2026 18:55
7d28e27 to
8e571dc
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
July 31, 2026 18:55
6ffad4f to
8590425
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
July 31, 2026 22:25
8e571dc to
7e33e73
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
July 31, 2026 22:25
8590425 to
a9ae3c0
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 3, 2026 01:07
7e33e73 to
2300e23
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 3, 2026 01:07
a9ae3c0 to
562662d
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 3, 2026 01:14
2300e23 to
d9b3232
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 3, 2026 01:14
562662d to
1488f9c
Compare
mzschwartz5
marked this pull request as ready for review
August 3, 2026 02:03
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 3, 2026 19:32
d9b3232 to
400740e
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 3, 2026 19:32
1488f9c to
a32f062
Compare
8 tasks
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 10, 2026 19:39
400740e to
9d74f09
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 10, 2026 19:39
a32f062 to
28f2e58
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 18, 2026 17:20
9d74f09 to
a33ee73
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 18, 2026 17:20
28f2e58 to
8160451
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 18, 2026 17:28
a33ee73 to
96fb786
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 18, 2026 17:28
8160451 to
feb488c
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 19, 2026 17:08
96fb786 to
33c9864
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 19, 2026 17:08
feb488c to
0aee935
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 19, 2026 19:38
33c9864 to
ed8db86
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 19, 2026 19:38
0aee935 to
b6c2e9b
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 20, 2026 14:17
ed8db86 to
386c5ae
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 20, 2026 14:17
fc6ecd5 to
6d99067
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 20, 2026 14:33
386c5ae to
07657ce
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 20, 2026 14:33
6d99067 to
0b183ea
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 21, 2026 16:14
07657ce to
c3424c2
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 21, 2026 16:14
0b183ea to
333c1db
Compare
mzschwartz5
force-pushed
the
model-clipping-pipeline-wiring
branch
from
August 21, 2026 16:16
c3424c2 to
33c58e4
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 21, 2026 16:16
333c1db to
7dc4085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dead code paths and files previously used by clipping polygons for SDF-based clipping. It adds deprecation warnings for the
qualityanddebugShowDistanceTextureproperties ofClippingPolygonCollection, as those fields no longer have meaning with the new implementation (and have been replaced with no-ops). It also adds deprecations for thedestroyfunctions ofClippingPolygonCollection, as the collection itself no longer owns any GPU resources to be destroyed.Love to see it! (and those additions are mostly regarding the deprecation warnings!)

Issue number and link
TODO
Testing plan
Regression testing + following the testing plan of #13647
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):
PR Dependency Tree
This tree was auto-generated by Charcoal