ClippingPolygon immutable positions (performance)

[mzschwartz5]

Description

Inspired by #13273 (which has drifted significantly in light of the new clipping polygon implementation this PR builds on). This PR makes the positions of ClippingPolgyons immutable (which is a breaking change!). The reason: if we can guarantee these positions do not change, we can get rid of dirty checks that occur per-vertex-per-frame. These checks are expensive for large collections (and at the high frequency of 60+ FPS). Instead, users can remove-and-readd (new) polygons. This isn't cheap (requires texture rebakes), but it's at least explicit / easier to detect (and respond to once rather than 60 times a second).

The original PR didn't quite land on a consensus of how to implement this. See my comment here on how I've decided to approach it.

Issue number and link

Part of #12258

Testing plan

This sandcastle (link is for this branch), is good for testing. It allows you to vary polygon count and polygon vertex count. Try it here and on main and compare the FPS -- it should be a pretty obvious difference.

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

AI acknowledgment

• I used AI to generate content in this PR
• If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

PR Dependency Tree

• PR Clipping polygon buffer migration #13623
  • PR Vector Textures for Polygon Clipping #13635
    • PR Clipping texture plumbing #13636
      • PR Shader rework for terrain polygon clipping #13637
        • PR Remove SDF polygon clipping from Globe #13638
          • PR Model clipping rework foundation #13641
            • PR Model polygon clipping shader impl #13647
              • PR Remove polygon clipping sdf path #13654
                • PR Clipping Polygon Holes #13660
                  • PR ClippingPolygon immutable positions (performance) #13665 👈

This tree was auto-generated by Charcoal

[github-actions]

Thank you for the pull request, @mzschwartz5!

✅ We can confirm we have a CLA on file for you.

[danielzhong]

Don't forget to add CHANGES.md later!

[plainheart]

I noticed a small typo in the deprecation message. ClippingPolygon.computeRectangle should be deprecated as of version 1.145 instead of 1.144, since 1.144 is already released.