Skip to content

Model clipping rework foundation - #13641

Open
mzschwartz5 wants to merge 8 commits into
remove-old-terrain-clipping-detailsfrom
model-clipping-foundation
Open

Model clipping rework foundation#13641
mzschwartz5 wants to merge 8 commits into
remove-old-terrain-clipping-detailsfrom
model-clipping-foundation

Conversation

@mzschwartz5

@mzschwartz5 mzschwartz5 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is the model-and-3d-tile version of this earlier PR for globe/terrain rendering. A Model now calls the new requestRectangleData API of its ClippingPolygonCollection to create textures for vector-based polygon clipping.

The next PR wires up these textures as shader uniforms and makes the shader changes to use them / swap out SDF-based clipping for vector-based clipping.

Issue number and link

TODO: needs issue

Testing plan

There are no behavioral changes here -- only more data added to the Model class. Regression testing on your favorite model sandcastle (and/or 3D tiles) is sufficient.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

PR Dependency Tree

This tree was auto-generated by Charcoal

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @mzschwartz5!

✅ We can confirm we have a CLA on file for you.

@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 0d13561 to faef7cf Compare July 29, 2026 18:56
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from ae1a488 to a40c15a Compare July 29, 2026 18:56
@mzschwartz5
mzschwartz5 marked this pull request as ready for review July 30, 2026 15:57
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from faef7cf to 4764eef Compare July 30, 2026 22:21
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from e8468e5 to 3d0a338 Compare July 30, 2026 22:21
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 4764eef to 41fea28 Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 3d0a338 to 1ca1288 Compare July 31, 2026 16:57
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 41fea28 to c6cd277 Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 1ca1288 to 3b05a75 Compare July 31, 2026 18:55
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from c6cd277 to 86820f6 Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 3b05a75 to f00e208 Compare July 31, 2026 22:25
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 86820f6 to b3d194c Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from f00e208 to 659da5a Compare August 3, 2026 01:07
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from b3d194c to 3a8628b Compare August 3, 2026 01:14
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 659da5a to 8a613bb Compare August 3, 2026 01:14
@mzschwartz5 mzschwartz5 mentioned this pull request Aug 3, 2026
8 tasks
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 3a8628b to 2b5215d Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 8a613bb to d928918 Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 2b5215d to 1b750d4 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from d928918 to 5a605d4 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 1b750d4 to bd076d8 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 5a605d4 to 089edce Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from bd076d8 to 34a3f83 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from c8e6595 to 21e6272 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 34a3f83 to 6635d0d Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 21e6272 to 929c801 Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 6635d0d to 05ee4c7 Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 929c801 to 9bb06d3 Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 05ee4c7 to 63f2394 Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 9bb06d3 to 00ecd6a Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from 63f2394 to ce89cf6 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 00ecd6a to 4090307 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the remove-old-terrain-clipping-details branch from ce89cf6 to a8f1d7f Compare August 21, 2026 16:16
@mzschwartz5
mzschwartz5 force-pushed the model-clipping-foundation branch from 4090307 to 13cf94b Compare August 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant