Model clipping rework foundation - #13641
Open
mzschwartz5 wants to merge 8 commits into
Open
Conversation
This was referenced Jul 21, 2026
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
This was referenced Jul 23, 2026
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 29, 2026 18:56
0d13561 to
faef7cf
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
July 29, 2026 18:56
ae1a488 to
a40c15a
Compare
mzschwartz5
marked this pull request as ready for review
July 30, 2026 15:57
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 30, 2026 22:21
faef7cf to
4764eef
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
July 30, 2026 22:21
e8468e5 to
3d0a338
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 16:57
4764eef to
41fea28
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
July 31, 2026 16:57
3d0a338 to
1ca1288
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 18:55
41fea28 to
c6cd277
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
July 31, 2026 18:55
1ca1288 to
3b05a75
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
July 31, 2026 22:25
c6cd277 to
86820f6
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
July 31, 2026 22:25
3b05a75 to
f00e208
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 01:07
86820f6 to
b3d194c
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 3, 2026 01:07
f00e208 to
659da5a
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 01:14
b3d194c to
3a8628b
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 3, 2026 01:14
659da5a to
8a613bb
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 3, 2026 19:32
3a8628b to
2b5215d
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 3, 2026 19:32
8a613bb to
d928918
Compare
8 tasks
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 10, 2026 19:39
2b5215d to
1b750d4
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 10, 2026 19:39
d928918 to
5a605d4
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 18, 2026 17:20
1b750d4 to
bd076d8
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 18, 2026 17:20
5a605d4 to
089edce
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 19, 2026 17:08
bd076d8 to
34a3f83
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 19, 2026 17:08
c8e6595 to
21e6272
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 19, 2026 19:38
34a3f83 to
6635d0d
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 19, 2026 19:38
21e6272 to
929c801
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 20, 2026 14:17
6635d0d to
05ee4c7
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 20, 2026 14:17
929c801 to
9bb06d3
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 20, 2026 14:33
05ee4c7 to
63f2394
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 20, 2026 14:33
9bb06d3 to
00ecd6a
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 21, 2026 16:14
63f2394 to
ce89cf6
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 21, 2026 16:14
00ecd6a to
4090307
Compare
mzschwartz5
force-pushed
the
remove-old-terrain-clipping-details
branch
from
August 21, 2026 16:16
ce89cf6 to
a8f1d7f
Compare
mzschwartz5
force-pushed
the
model-clipping-foundation
branch
from
August 21, 2026 16:16
4090307 to
13cf94b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the model-and-3d-tile version of this earlier PR for globe/terrain rendering. A
Modelnow calls the newrequestRectangleDataAPI of itsClippingPolygonCollectionto create textures for vector-based polygon clipping.The next PR wires up these textures as shader uniforms and makes the shader changes to use them / swap out SDF-based clipping for vector-based clipping.
Issue number and link
TODO: needs issue
Testing plan
There are no behavioral changes here -- only more data added to the Model class. Regression testing on your favorite model sandcastle (and/or 3D tiles) is sufficient.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):
PR Dependency Tree
This tree was auto-generated by Charcoal