Skip to content

Clipping Polygon Holes - #13660

Open
mzschwartz5 wants to merge 2 commits into
remove-polygon-clipping-sdf-pathfrom
clipping-polygon-holes
Open

Clipping Polygon Holes#13660
mzschwartz5 wants to merge 2 commits into
remove-polygon-clipping-sdf-pathfrom
clipping-polygon-holes

Conversation

@mzschwartz5

@mzschwartz5 mzschwartz5 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Clipping polygons with holes (regular and inverse clipping):

image image

This PR adds a "holes" option to the ClippingPolygons API. Users specify the positions of the clipping polygon outline, as a list of Cartesian3, and a holes as a list of lists of Cartesian3 (where each sublist represents the outline of one hole). Because we now use BufferPolygonCollection as the backing data structure for clipping polygons, alongside the vector shader framework, we get support for holes nearly for free.

Issue number and link

#12939

Testing plan

This sandcastle demonstrates holes -- you can try it out with terrain or 3D tiles, and regular clipping or inverse.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

PR Dependency Tree

This tree was auto-generated by Charcoal

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @mzschwartz5!

✅ We can confirm we have a CLA on file for you.

@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 1488f9c to a32f062 Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from 3ab442b to e2f9d8f Compare August 3, 2026 19:32
@mzschwartz5
mzschwartz5 marked this pull request as ready for review August 5, 2026 15:45
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from a32f062 to 28f2e58 Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from e2f9d8f to a2cf88a Compare August 10, 2026 19:39
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 28f2e58 to 8160451 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from a2cf88a to c54c525 Compare August 18, 2026 17:20
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 8160451 to feb488c Compare August 18, 2026 17:28
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from c54c525 to 15b8f39 Compare August 18, 2026 17:28
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from feb488c to 0aee935 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from 15b8f39 to 0e904c0 Compare August 19, 2026 17:08
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 0aee935 to b6c2e9b Compare August 19, 2026 19:38
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch 3 times, most recently from 25d6e02 to 434e171 Compare August 20, 2026 12:50
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from fc6ecd5 to 6d99067 Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from 434e171 to c50ae6f Compare August 20, 2026 14:17
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 6d99067 to 0b183ea Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from c50ae6f to 3c04c7d Compare August 20, 2026 14:33
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 0b183ea to 333c1db Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from 3c04c7d to 1bb2726 Compare August 21, 2026 16:14
@mzschwartz5
mzschwartz5 force-pushed the remove-polygon-clipping-sdf-path branch from 333c1db to 7dc4085 Compare August 21, 2026 16:16
@mzschwartz5
mzschwartz5 force-pushed the clipping-polygon-holes branch from 1bb2726 to 6ff03a6 Compare August 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant