Clipping Polygon Holes - #13660
Open
mzschwartz5 wants to merge 2 commits into
Open
Conversation
This was referenced Aug 3, 2026
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
6 tasks
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 3, 2026 19:32
1488f9c to
a32f062
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 3, 2026 19:32
3ab442b to
e2f9d8f
Compare
This was referenced Aug 3, 2026
mzschwartz5
marked this pull request as ready for review
August 5, 2026 15:45
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 10, 2026 19:39
a32f062 to
28f2e58
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 10, 2026 19:39
e2f9d8f to
a2cf88a
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 18, 2026 17:20
28f2e58 to
8160451
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 18, 2026 17:20
a2cf88a to
c54c525
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 18, 2026 17:28
8160451 to
feb488c
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 18, 2026 17:28
c54c525 to
15b8f39
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 19, 2026 17:08
feb488c to
0aee935
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 19, 2026 17:08
15b8f39 to
0e904c0
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 19, 2026 19:38
0aee935 to
b6c2e9b
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
3 times, most recently
from
August 20, 2026 12:50
25d6e02 to
434e171
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 20, 2026 14:17
fc6ecd5 to
6d99067
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 20, 2026 14:17
434e171 to
c50ae6f
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 20, 2026 14:33
6d99067 to
0b183ea
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 20, 2026 14:33
c50ae6f to
3c04c7d
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 21, 2026 16:14
0b183ea to
333c1db
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 21, 2026 16:14
3c04c7d to
1bb2726
Compare
mzschwartz5
force-pushed
the
remove-polygon-clipping-sdf-path
branch
from
August 21, 2026 16:16
333c1db to
7dc4085
Compare
mzschwartz5
force-pushed
the
clipping-polygon-holes
branch
from
August 21, 2026 16:16
1bb2726 to
6ff03a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clipping polygons with holes (regular and inverse clipping):
This PR adds a "holes" option to the
ClippingPolygonsAPI. Users specify the positions of the clipping polygon outline, as a list ofCartesian3, and a holes as a list of lists ofCartesian3(where each sublist represents the outline of one hole). Because we now useBufferPolygonCollectionas the backing data structure for clipping polygons, alongside the vector shader framework, we get support for holes nearly for free.Issue number and link
#12939
Testing plan
This sandcastle demonstrates holes -- you can try it out with terrain or 3D tiles, and regular clipping or inverse.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):
PR Dependency Tree
This tree was auto-generated by Charcoal